Commit f76178dc authored by Raju Lakkaraju's avatar Raju Lakkaraju Committed by David S. Miller
Browse files

net: phy: mscc: add ethtool statistics counters 



There are a few counters available in the PHY: receive errors, false
carriers, link disconnects, media CRC errors and valids counters.

So let's expose those in the PHY driver.

Use the priv structure as the next PHY to be supported has a few
additional counters.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarRaju Lakkaraju <Raju.Lakkaraju@microsemi.com>
Signed-off-by: default avatarQuentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6a0bfbbe

drivers/net/phy/mscc.c

+119 −0
Original line number Diff line number Diff line
@@ -33,6 +33,11 @@ enum rgmii_rx_clock_delay { 
#define DISABLE_PAIR_SWAP_CORR_MASK	  0x0020

#define DISABLE_POLARITY_CORR_MASK	  0x0010



#define MSCC_PHY_ERR_RX_CNT		  19

#define MSCC_PHY_ERR_FALSE_CARRIER_CNT	  20

#define MSCC_PHY_ERR_LINK_DISCONNECT_CNT  21

#define ERR_CNT_MASK			  GENMASK(7, 0)



#define MSCC_PHY_EXT_PHY_CNTL_1           23

#define MAC_IF_SELECTION_MASK             0x1800

#define MAC_IF_SELECTION_GMII             0
@@ -64,6 +69,9 @@ enum rgmii_rx_clock_delay { 
#define MSCC_PHY_PAGE_EXTENDED_2	  0x0002 /* Extended reg - page 2 */



/* Extended Page 1 Registers */

#define MSCC_PHY_CU_MEDIA_CRC_VALID_CNT	  18

#define VALID_CRC_CNT_CRC_MASK		  GENMASK(13, 0)



#define MSCC_PHY_EXT_MODE_CNTL		  19

#define FORCE_MDI_CROSSOVER_MASK	  0x000C

#define FORCE_MDI_CROSSOVER_MDIX	  0x000C
@@ -74,6 +82,8 @@ enum rgmii_rx_clock_delay { 
#define DOWNSHIFT_EN			  0x0010

#define DOWNSHIFT_CNTL_POS		  2



#define MSCC_PHY_EXT_PHY_CNTL_4		  23



/* Extended Page 2 Registers */

#define MSCC_PHY_RGMII_CNTL		  20

#define RGMII_RX_CLK_DELAY_MASK		  0x0070
@@ -119,11 +129,50 @@ enum rgmii_rx_clock_delay { 
				BIT(VSC8531_FORCE_LED_OFF) | \

				BIT(VSC8531_FORCE_LED_ON))



struct vsc85xx_hw_stat {

	const char *string;

	u8 reg;

	u16 page;

	u16 mask;

};



static const struct vsc85xx_hw_stat vsc85xx_hw_stats[] = {

	{

		.string	= "phy_receive_errors",

		.reg	= MSCC_PHY_ERR_RX_CNT,

		.page	= MSCC_PHY_PAGE_STANDARD,

		.mask	= ERR_CNT_MASK,

	}, {

		.string	= "phy_false_carrier",

		.reg	= MSCC_PHY_ERR_FALSE_CARRIER_CNT,

		.page	= MSCC_PHY_PAGE_STANDARD,

		.mask	= ERR_CNT_MASK,

	}, {

		.string	= "phy_cu_media_link_disconnect",

		.reg	= MSCC_PHY_ERR_LINK_DISCONNECT_CNT,

		.page	= MSCC_PHY_PAGE_STANDARD,

		.mask	= ERR_CNT_MASK,

	}, {

		.string	= "phy_cu_media_crc_good_count",

		.reg	= MSCC_PHY_CU_MEDIA_CRC_VALID_CNT,

		.page	= MSCC_PHY_PAGE_EXTENDED,

		.mask	= VALID_CRC_CNT_CRC_MASK,

	}, {

		.string	= "phy_cu_media_crc_error_count",

		.reg	= MSCC_PHY_EXT_PHY_CNTL_4,

		.page	= MSCC_PHY_PAGE_EXTENDED,

		.mask	= ERR_CNT_MASK,

	},

};



struct vsc8531_private {

	int rate_magic;

	u16 supp_led_modes;

	u32 leds_mode[MAX_LEDS];

	u8 nleds;

	const struct vsc85xx_hw_stat *hw_stats;

	u64 *stats;

	int nstats;

};



#ifdef CONFIG_OF_MDIO
@@ -150,6 +199,58 @@ static int vsc85xx_phy_write_page(struct phy_device *phydev, int page) 
	return __phy_write(phydev, MSCC_EXT_PAGE_ACCESS, page);

}



static int vsc85xx_get_sset_count(struct phy_device *phydev)

{

	struct vsc8531_private *priv = phydev->priv;



	if (!priv)

		return 0;



	return priv->nstats;

}



static void vsc85xx_get_strings(struct phy_device *phydev, u8 *data)

{

	struct vsc8531_private *priv = phydev->priv;

	int i;



	if (!priv)

		return;



	for (i = 0; i < priv->nstats; i++)

		strlcpy(data + i * ETH_GSTRING_LEN, priv->hw_stats[i].string,

			ETH_GSTRING_LEN);

}



static u64 vsc85xx_get_stat(struct phy_device *phydev, int i)

{

	struct vsc8531_private *priv = phydev->priv;

	int val;



	val = phy_read_paged(phydev, priv->hw_stats[i].page,

			     priv->hw_stats[i].reg);

	if (val < 0)

		return U64_MAX;



	val = val & priv->hw_stats[i].mask;

	priv->stats[i] += val;



	return priv->stats[i];

}



static void vsc85xx_get_stats(struct phy_device *phydev,

			      struct ethtool_stats *stats, u64 *data)

{

	struct vsc8531_private *priv = phydev->priv;

	int i;



	if (!priv)

		return;



	for (i = 0; i < priv->nstats; i++)

		data[i] = vsc85xx_get_stat(phydev, i);

}



static int vsc85xx_led_cntl_set(struct phy_device *phydev,

				u8 led_num,

				u8 mode)
@@ -643,6 +744,12 @@ static int vsc85xx_probe(struct phy_device *phydev) 
	vsc8531->rate_magic = rate_magic;

	vsc8531->nleds = 2;

	vsc8531->supp_led_modes = VSC85XX_SUPP_LED_MODES;

	vsc8531->hw_stats = vsc85xx_hw_stats;

	vsc8531->nstats = ARRAY_SIZE(vsc85xx_hw_stats);

	vsc8531->stats = devm_kmalloc_array(&phydev->mdio.dev, vsc8531->nstats,

					    sizeof(u64), GFP_KERNEL);

	if (!vsc8531->stats)

		return -ENOMEM;



	return vsc85xx_dt_led_modes_get(phydev, default_mode);

}
@@ -671,6 +778,9 @@ static struct phy_driver vsc85xx_driver[] = { 
	.set_tunable	= &vsc85xx_set_tunable,

	.read_page	= &vsc85xx_phy_read_page,

	.write_page	= &vsc85xx_phy_write_page,

	.get_sset_count = &vsc85xx_get_sset_count,

	.get_strings    = &vsc85xx_get_strings,

	.get_stats      = &vsc85xx_get_stats,

},

{

	.phy_id		= PHY_ID_VSC8531,
@@ -694,6 +804,9 @@ static struct phy_driver vsc85xx_driver[] = { 
	.set_tunable	= &vsc85xx_set_tunable,

	.read_page	= &vsc85xx_phy_read_page,

	.write_page	= &vsc85xx_phy_write_page,

	.get_sset_count = &vsc85xx_get_sset_count,

	.get_strings    = &vsc85xx_get_strings,

	.get_stats      = &vsc85xx_get_stats,

},

{

	.phy_id		= PHY_ID_VSC8540,
@@ -717,6 +830,9 @@ static struct phy_driver vsc85xx_driver[] = { 
	.set_tunable	= &vsc85xx_set_tunable,

	.read_page	= &vsc85xx_phy_read_page,

	.write_page	= &vsc85xx_phy_write_page,

	.get_sset_count = &vsc85xx_get_sset_count,

	.get_strings    = &vsc85xx_get_strings,

	.get_stats      = &vsc85xx_get_stats,

},

{

	.phy_id		= PHY_ID_VSC8541,
@@ -740,6 +856,9 @@ static struct phy_driver vsc85xx_driver[] = { 
	.set_tunable	= &vsc85xx_set_tunable,

	.read_page	= &vsc85xx_phy_read_page,

	.write_page	= &vsc85xx_phy_write_page,

	.get_sset_count = &vsc85xx_get_sset_count,

	.get_strings    = &vsc85xx_get_strings,

	.get_stats      = &vsc85xx_get_stats,

}



};

CRA Git | Maintained and supported by SUSTech CRA and CCSE