Commit f759e2b4 authored by Xiao Guangrong's avatar Xiao Guangrong Committed by Avi Kivity
Browse files

KVM: MMU: avoid pte_list_desc running out in kvm_mmu_pte_write 



kvm_mmu_pte_write is unsafe since we need to alloc pte_list_desc in the
function when spte is prefetched, unfortunately, we can not know how many
spte need to be prefetched on this path, that means we can use out of the
free  pte_list_desc object in the cache, and BUG_ON() is triggered, also some
path does not fill the cache, such as INS instruction emulated that does not
trigger page fault

Signed-off-by: default avatarXiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
parent 51cfe38e

arch/x86/kvm/mmu.c

+20 −5
Original line number Diff line number Diff line
@@ -593,6 +593,11 @@ static int mmu_topup_memory_cache(struct kvm_mmu_memory_cache *cache, 
	return 0;

}



static int mmu_memory_cache_free_objects(struct kvm_mmu_memory_cache *cache)

{

	return cache->nobjs;

}



static void mmu_free_memory_cache(struct kvm_mmu_memory_cache *mc,

				  struct kmem_cache *cache)

{
@@ -970,6 +975,14 @@ static unsigned long *gfn_to_rmap(struct kvm *kvm, gfn_t gfn, int level) 
	return &linfo->rmap_pde;

}



static bool rmap_can_add(struct kvm_vcpu *vcpu)

{

	struct kvm_mmu_memory_cache *cache;



	cache = &vcpu->arch.mmu_pte_list_desc_cache;

	return mmu_memory_cache_free_objects(cache);

}



static int rmap_add(struct kvm_vcpu *vcpu, u64 *spte, gfn_t gfn)

{

	struct kvm_mmu_page *sp;
@@ -3586,6 +3599,12 @@ void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa, 
		break;

	}



	/*

	 * No need to care whether allocation memory is successful

	 * or not since pte prefetch is skiped if it does not have

	 * enough objects in the cache.

	 */

	mmu_topup_memory_caches(vcpu);

	spin_lock(&vcpu->kvm->mmu_lock);

	if (atomic_read(&vcpu->kvm->arch.invlpg_counter) != invlpg_counter)

		gentry = 0;
@@ -3656,7 +3675,7 @@ void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa, 
			mmu_page_zap_pte(vcpu->kvm, sp, spte);

			if (gentry &&

			      !((sp->role.word ^ vcpu->arch.mmu.base_role.word)

			      & mask.word))

			      & mask.word) && rmap_can_add(vcpu))

				mmu_pte_write_new_pte(vcpu, sp, spte, &gentry);

			if (!remote_flush && need_remote_flush(entry, *spte))

				remote_flush = true;
@@ -3717,10 +3736,6 @@ int kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gva_t cr2, u32 error_code, 
		goto out;

	}



	r = mmu_topup_memory_caches(vcpu);

	if (r)

		goto out;



	er = x86_emulate_instruction(vcpu, cr2, 0, insn, insn_len);



	switch (er) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE