Commit f73bb9b3 authored Mar 03, 2013 by Arnd Bergmann Committed by Vinod Koul Mar 30, 2013

dmaengine: dw_dma: fix endianess for DT xlate function



As reported by Wu Fengguang's build robot tracking sparse warnings, the
dma_spec arguments in the dw_dma_xlate are already byte swapped on
little-endian platforms and must not get swapped again. This code is
currently not used anywhere, but will be used in Linux 3.10 when the
ARM SPEAr platform starts using the generic DMA DT binding.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 8bb96604

drivers/dma/dw_dmac.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1276,9 +1276,9 @@ static struct dma_chan dw_dma_xlate(struct of_phandle_args dma_spec,
		if (dma_spec->args_count != 3)
		return NULL;

		fargs.req = be32_to_cpup(dma_spec->args+0);
		fargs.src = be32_to_cpup(dma_spec->args+1);
		fargs.dst = be32_to_cpup(dma_spec->args+2);
		fargs.req = dma_spec->args[0];
		fargs.src = dma_spec->args[1];
		fargs.dst = dma_spec->args[2];

		if (WARN_ON(fargs.req >= DW_DMA_MAX_NR_REQUESTS \|\|
		fargs.src >= dw->nr_masters \|\|

Admin message