Commit f7357273 authored Jul 22, 2015 by Goldwyn Rodrigues Committed by NeilBrown Jul 24, 2015

md: Skip cluster setup in case of error while reading bitmap



If the bitmap read fails, the error code set is -EINVAL. However,
we don't check for errors and go ahead with cluster_setup.
Skip the cluster setup in case of error.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>

parent 34cab6f4

drivers/md/bitmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -680,7 +680,7 @@ out:
		kunmap_atomic(sb);
		/* Assiging chunksize is required for "re_read" */
		bitmap->mddev->bitmap_info.chunksize = chunksize;
		if (nodes && (bitmap->cluster_slot < 0)) {
		if (err == 0 && nodes && (bitmap->cluster_slot < 0)) {
		err = md_setup_cluster(bitmap->mddev, nodes);
		if (err) {
		pr_err("%s: Could not setup cluster service (%d)\n",

Admin message