Commit f72b85b8 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: remove ieee80211_key_removed 



This API call was intended to be used by drivers
if they want to optimize key handling by removing
one key when another is added. Remove it since no
driver is using it. If needed, it can always be
added back.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 31ee67a1

Documentation/DocBook/80211.tmpl

+0 −1
Original line number Diff line number Diff line
@@ -404,7 +404,6 @@ 
!Finclude/net/mac80211.h ieee80211_get_tkip_p1k

!Finclude/net/mac80211.h ieee80211_get_tkip_p1k_iv

!Finclude/net/mac80211.h ieee80211_get_tkip_p2k

!Finclude/net/mac80211.h ieee80211_key_removed

      </chapter>



      <chapter id="powersave">

include/net/mac80211.h

+0 −16
Original line number Diff line number Diff line
@@ -3591,22 +3591,6 @@ void ieee80211_chswitch_done(struct ieee80211_vif *vif, bool success); 
void ieee80211_request_smps(struct ieee80211_vif *vif,

			    enum ieee80211_smps_mode smps_mode);



/**

 * ieee80211_key_removed - disable hw acceleration for key

 * @key_conf: The key hw acceleration should be disabled for

 *

 * This allows drivers to indicate that the given key has been

 * removed from hardware acceleration, due to a new key that

 * was added. Don't use this if the key can continue to be used

 * for TX, if the key restriction is on RX only it is permitted

 * to keep the key for TX only and not call this function.

 *

 * Due to locking constraints, it may only be called during

 * @set_key. This function must be allowed to sleep, and the

 * key it tries to disable may still be used until it returns.

 */

void ieee80211_key_removed(struct ieee80211_key_conf *key_conf);



/**

 * ieee80211_ready_on_channel - notification of remain-on-channel start

 * @hw: pointer as obtained from ieee80211_alloc_hw()

net/mac80211/key.c

+0 −20
Original line number Diff line number Diff line
@@ -194,26 +194,6 @@ static void ieee80211_key_disable_hw_accel(struct ieee80211_key *key) 
	key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;

}



void ieee80211_key_removed(struct ieee80211_key_conf *key_conf)

{

	struct ieee80211_key *key;



	key = container_of(key_conf, struct ieee80211_key, conf);



	might_sleep();

	assert_key_lock(key->local);



	key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;



	/*

	 * Flush TX path to avoid attempts to use this key

	 * after this function returns. Until then, drivers

	 * must be prepared to handle the key.

	 */

	synchronize_rcu();

}

EXPORT_SYMBOL_GPL(ieee80211_key_removed);



static void __ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata,

					int idx, bool uni, bool multi)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE