Commit f70d9a24 authored Aug 26, 2019 by Wei Yongjun Committed by Ulf Hansson Sep 11, 2019

mmc: sdhci-of-aspeed: Fix return value check in aspeed_sdc_probe()



In case of error, the function of_platform_device_create() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent f47fdb85

drivers/mmc/host/sdhci-of-aspeed.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -261,9 +261,9 @@ static int aspeed_sdc_probe(struct platform_device *pdev)
		struct platform_device *cpdev;

		cpdev = of_platform_device_create(child, NULL, &pdev->dev);
		if (IS_ERR(cpdev)) {
		if (!cpdev) {
		of_node_put(child);
		ret = PTR_ERR(cpdev);
		ret = -ENODEV;
		goto err_clk;
		}
		}

Admin message