Commit f70556c8 authored Oct 10, 2018 by Gustavo A. R. Silva Committed by Steve French Oct 23, 2018

smb2: fix uninitialized variable bug in smb2_ioctl_query_info

There is a potential execution path in which variable *resp_buftype*
is passed as an argument to function free_rsp_buf(), in which it is
used in a comparison without being properly initialized previously.

Fix this by initializing variable *resp_buftype* to CIFS_NO_BUFFER
in order to avoid unpredictable or unintended results.

Addresses-Coverity-ID: 1473971 ("Uninitialized scalar variable")
Fixes: c5d25bdb2967 ("cifs: add IOCTL for QUERY_INFO passthrough to userspace")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>

parent f5b05d62

fs/cifs/smb2ops.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1133,7 +1133,7 @@ smb2_ioctl_query_info(const unsigned int xid,
		struct smb_rqst rqst;
		struct kvec iov[1];
		struct kvec rsp_iov;
		int resp_buftype;
		int resp_buftype = CIFS_NO_BUFFER;
		struct smb2_query_info_rsp *rsp = NULL;
		void *buffer;

Admin message