Commit f6f34b43 authored Oct 07, 2016 by Srikar Dronamraju Committed by Linus Torvalds Oct 07, 2016

mm: introduce arch_reserved_kernel_pages()

Currently arch specific code can reserve memory blocks but
alloc_large_system_hash() may not take it into consideration when sizing
the hashes.  This can lead to bigger hash than required and lead to no
available memory for other purposes.  This is specifically true for
systems with CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled.

One approach to solve this problem would be to walk through the memblock
regions and calculate the available memory and base the size of hash
system on the available memory.

The other approach would be to depend on the architecture to provide the
number of pages that are reserved.  This change provides hooks to allow
the architecture to provide the required info.

Link: http://lkml.kernel.org/r/1472476010-4709-2-git-send-email-srikar@linux.vnet.ibm.com


Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Suggested-by: Mel Gorman <mgorman@techsingularity.net>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: Hari Bathini <hbathini@linux.vnet.ibm.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c9634cf0

include/linux/mm.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -1924,6 +1924,9 @@ extern void show_mem(unsigned int flags);
		extern long si_mem_available(void);
		extern void si_meminfo(struct sysinfo * val);
		extern void si_meminfo_node(struct sysinfo *val, int nid);
		#ifdef __HAVE_ARCH_RESERVED_KERNEL_PAGES
		extern unsigned long arch_reserved_kernel_pages(void);
		#endif

		extern __printf(3, 4)
		void warn_alloc_failed(gfp_t gfp_mask, unsigned int order,

mm/page_alloc.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -6940,6 +6940,17 @@ static int __init set_hashdist(char *str)
		__setup("hashdist=", set_hashdist);
		#endif

		#ifndef __HAVE_ARCH_RESERVED_KERNEL_PAGES
		/*
		* Returns the number of pages that arch has reserved but
		* is not known to alloc_large_system_hash().
		*/
		static unsigned long __init arch_reserved_kernel_pages(void)
		{
		return 0;
		}
		#endif

		/*
		* allocate a large system hash table from bootmem
		* - it is assumed that the hash table must contain an exact power-of-2
		@@ -6964,6 +6975,7 @@ void __init alloc_large_system_hash(const char tablename,
		if (!numentries) {
		/* round applicable memory size up to nearest megabyte */
		numentries = nr_kernel_pages;
		numentries -= arch_reserved_kernel_pages();

		/* It isn't necessary when PAGE_SIZE >= 1MB */
		if (PAGE_SHIFT < 20)

Admin message