net/ncsi: Fix the payload copying for the request coming from Netlink (f6edbf2d) · Commits · 戴 / test

The request coming from Netlink should use the OEM generic handler. The standard command handler expects payload in bytes/words/dwords but the actual payload is stored in data if the request is coming from Netlink. Signed-off-by:

Justin Lee <justin.lee1@dell.com> Reviewed-by:

Vijay Khemka <vijaykhemka@fb.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/ncsi/ncsi-cmd.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -309,14 +309,21 @@ static struct ncsi_request ncsi_alloc_command(struct ncsi_cmd_arg nca)

		int ncsi_xmit_cmd(struct ncsi_cmd_arg *nca)
		{
		struct ncsi_cmd_handler *nch = NULL;
		struct ncsi_request *nr;
		unsigned char type;
		struct ethhdr *eh;
		struct ncsi_cmd_handler *nch = NULL;
		int i, ret;

		/* Use OEM generic handler for Netlink request */
		if (nca->req_flags == NCSI_REQ_FLAG_NETLINK_DRIVEN)
		type = NCSI_PKT_CMD_OEM;
		else
		type = nca->type;

		/* Search for the handler */
		for (i = 0; i < ARRAY_SIZE(ncsi_cmd_handlers); i++) {
		if (ncsi_cmd_handlers[i].type == nca->type) {
		if (ncsi_cmd_handlers[i].type == type) {
		if (ncsi_cmd_handlers[i].handler)
		nch = &ncsi_cmd_handlers[i];
		else

Admin message