Commit f6d9db63 authored Mar 09, 2019 by Arseny Maslennikov Committed by Masahiro Yamada Mar 17, 2019

kbuild: deb-pkg: avoid implicit effects



* The man page for dpkg-source(1) notes:

>      -b, --build directory [format-specific-parameters]
>             Build  a  source  package  (--build since dpkg 1.17.14).
>             <...>
>
>             dpkg-source will build the source package with the first
>             format found in this ordered list: the format  indicated
>             with  the  --format  command  line  option,  the  format
>             indicated in debian/source/format, “1.0”.  The  fallback
>             to “1.0” is deprecated and will be removed at some point
>             in the future, you should always  document  the  desired
>             source   format  in  debian/source/format.  See  section
>             SOURCE PACKAGE FORMATS for an extensive  description  of
>             the various source package formats.

  Thus it would be more foolproof to explicitly use 1.0 (as we always
  did) than to rely on dpkg-source's defaults.

* In a similar vein, debian/rules is not made executable by mkdebian,
  and dpkg-source warns about that but still silently fixes the file.
  Let's be explicit once again.

Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

parent da9cfb87

scripts/package/mkdebian

+4 −1

Original line number	Diff line number	Diff line
		@@ -132,7 +132,9 @@ else
		echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST explicitly"
		fi

		mkdir -p debian/
		mkdir -p debian/source/
		echo "1.0" > debian/source/format

		echo $debarch > debian/arch
		extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev)"
		extra_build_depends="$extra_build_depends, $(if_enabled_echo CONFIG_SYSTEM_TRUSTED_KEYRING libssl-dev:native)"
		@@ -223,5 +225,6 @@ clean:

		binary: binary-arch
		EOF
		chmod +x debian/rules

		exit 0

Admin message