Commit f6d90b4f authored Nov 01, 2011 by Eric W. Biederman Committed by Linus Torvalds Nov 01, 2011

sysfs: Make sysfs_rename safe with sysfs_dirents in rbtrees.



In sysfs_rename we need to remove the optimization of not calling
sysfs_unlink_sibling and sysfs_link_sibling if the renamed parent
directory is not changing.  This optimization is no longer valid now
that sysfs dirents are stored in an rbtree sorted by name.

Move the assignment of s_ns before the call of sysfs_link_sibling.  With
no sysfs_dirent fields changing after the call of sysfs_link_sibling
this allows sysfs_link_sibling to take any of the directory entries into
account when it builds the rbtrees, and s_ns looks like a prime canidate
to be used in the rbtree in the future.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Greg KH <gregkh@suse.de>
Cc: David Miller <davem@davemloft.net>
Cc: Mikulas Patocka <mpatocka@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c87d5d59

fs/sysfs/dir.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -865,15 +865,13 @@ int sysfs_rename(struct sysfs_dirent *sd,
		sd->s_name = new_name;
		}

		/* Remove from old parent's list and insert into new parent's list. */
		if (sd->s_parent != new_parent_sd) {
		/* Move to the appropriate place in the appropriate directories rbtree. */
		sysfs_unlink_sibling(sd);
		sysfs_get(new_parent_sd);
		sysfs_put(sd->s_parent);
		sd->s_ns = new_ns;
		sd->s_parent = new_parent_sd;
		sysfs_link_sibling(sd);
		}
		sd->s_ns = new_ns;

		error = 0;
		out:

Admin message