Commit f6d4671a authored Mar 17, 2016 by Emmanuel Grumbach Committed by Johannes Berg Apr 05, 2016

mac80211: close the SP when we enqueue frames during the SP



Since we enqueued the frame that was supposed to be sent
during the SP, and that frame may very well cary the
IEEE80211_TX_STATUS_EOSP bit, we may never close the SP
(WLAN_STA_SP will never be cleared). If that happens, we
will not open any new SP and will never respond to any poll
frame from the client.
Clear WLAN_STA_SP manually if a frame that was polled during
the SP is queued because of a starting A-MPDU session. The
client may not see the EOSP bit, but it will at least be
able to poll new frames in another SP.

Reported-by: Alesya Shapira <alesya.shapira@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
[remove erroneous comment]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 4b559ec0

net/mac80211/tx.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1116,6 +1116,12 @@ static bool ieee80211_tx_prep_agg(struct ieee80211_tx_data *tx,
		reset_agg_timer = true;
		} else {
		queued = true;
		if (info->flags & IEEE80211_TX_CTL_NO_PS_BUFFER) {
		clear_sta_flag(tx->sta, WLAN_STA_SP);
		ps_dbg(tx->sta->sdata,
		"STA %pM aid %d: SP frame queued, close the SP w/o telling the peer\n",
		tx->sta->sta.addr, tx->sta->sta.aid);
		}
		info->control.vif = &tx->sdata->vif;
		info->flags \|= IEEE80211_TX_INTFL_NEED_TXPROCESSING;
		info->flags &= ~IEEE80211_TX_TEMPORARY_FLAGS;

Admin message