Commit f6d061d6 authored Dec 28, 2019 by YueHaibing Committed by Jessica Yu Jan 08, 2020

kernel/module: Fix memleak in module_add_modinfo_attrs()



In module_add_modinfo_attrs() if sysfs_create_file() fails
on the first iteration of the loop (so i = 0), we forget to
free the modinfo_attrs.

Fixes: bc6f2a75 ("kernel/module: Fix mem leak in module_add_modinfo_attrs")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>

parent ce2b617c

kernel/module.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1784,6 +1784,8 @@ static int module_add_modinfo_attrs(struct module *mod)
		error_out:
		if (i > 0)
		module_remove_modinfo_attrs(mod, --i);
		else
		kfree(mod->modinfo_attrs);
		return error;
		}

Admin message