Commit f6c90df8 authored Jul 31, 2019 by Stephen Boyd

clk: sprd: Don't reference clk_init_data after registration

A future patch is going to change semantics of clk_register() so that
clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
referencing this member here so that we don't run into NULL pointer
exceptions.

Cc: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20190731193517.237136-8-sboyd@kernel.org

Acked-by: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Chunyan Zhang <zhang.chunyan@linaro.org>

parent 09d4922d

drivers/clk/sprd/common.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -76,16 +76,17 @@ int sprd_clk_probe(struct device dev, struct clk_hw_onecell_data clkhw)
		struct clk_hw *hw;

		for (i = 0; i < clkhw->num; i++) {
		const char *name;

		hw = clkhw->hws[i];

		if (!hw)
		continue;

		name = hw->init->name;
		ret = devm_clk_hw_register(dev, hw);
		if (ret) {
		dev_err(dev, "Couldn't register clock %d - %s\n",
		i, hw->init->name);
		i, name);
		return ret;
		}
		}

Admin message