Commit f6c86a41 authored by Jean-Philippe Brucker's avatar Jean-Philippe Brucker Committed by Marc Zyngier
Browse files

irqchip/gic-v3: Change unsigned types for AArch32 compatibility 



This patch does a few simple compatibility-related changes:
- change the system register access prototypes to their actual size,
- homogenise mpidr accesses with unsigned long,
- force the 64bit register values to unsigned long long.

Note: the list registers are 64bit on GICv3, but the AArch32 vGIC driver
will need to split their values into two 32bit registers: LRn and LRCn.

Reviewed-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarJean-Philippe Brucker <jean-philippe.brucker@arm.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 7936e914

arch/arm64/include/asm/arch_gicv3.h

+19 −14
Original line number Diff line number Diff line
@@ -78,17 +78,22 @@ 


#include <linux/stringify.h>



/* Low level accessors */

/*

 * Low-level accessors

 *

 * These system registers are 32 bits, but we make sure that the compiler

 * sets the GP register's most significant bits to 0 with an explicit cast.

 */



static inline void gic_write_eoir(u64 irq)

static inline void gic_write_eoir(u32 irq)

{

	asm volatile("msr_s " __stringify(ICC_EOIR1_EL1) ", %0" : : "r" (irq));

	asm volatile("msr_s " __stringify(ICC_EOIR1_EL1) ", %0" : : "r" ((u64)irq));

	isb();

}



static inline void gic_write_dir(u64 irq)

static inline void gic_write_dir(u32 irq)

{

	asm volatile("msr_s " __stringify(ICC_DIR_EL1) ", %0" : : "r" (irq));

	asm volatile("msr_s " __stringify(ICC_DIR_EL1) ", %0" : : "r" ((u64)irq));

	isb();

}
@@ -122,20 +127,20 @@ static inline u64 gic_read_iar_cavium_thunderx(void) 
	return irqstat;

}



static inline void gic_write_pmr(u64 val)

static inline void gic_write_pmr(u32 val)

{

	asm volatile("msr_s " __stringify(ICC_PMR_EL1) ", %0" : : "r" (val));

	asm volatile("msr_s " __stringify(ICC_PMR_EL1) ", %0" : : "r" ((u64)val));

}



static inline void gic_write_ctlr(u64 val)

static inline void gic_write_ctlr(u32 val)

{

	asm volatile("msr_s " __stringify(ICC_CTLR_EL1) ", %0" : : "r" (val));

	asm volatile("msr_s " __stringify(ICC_CTLR_EL1) ", %0" : : "r" ((u64)val));

	isb();

}



static inline void gic_write_grpen1(u64 val)

static inline void gic_write_grpen1(u32 val)

{

	asm volatile("msr_s " __stringify(ICC_GRPEN1_EL1) ", %0" : : "r" (val));

	asm volatile("msr_s " __stringify(ICC_GRPEN1_EL1) ", %0" : : "r" ((u64)val));

	isb();

}
@@ -144,7 +149,7 @@ static inline void gic_write_sgi1r(u64 val) 
	asm volatile("msr_s " __stringify(ICC_SGI1R_EL1) ", %0" : : "r" (val));

}



static inline u64 gic_read_sre(void)

static inline u32 gic_read_sre(void)

{

	u64 val;
@@ -152,9 +157,9 @@ static inline u64 gic_read_sre(void) 
	return val;

}



static inline void gic_write_sre(u64 val)

static inline void gic_write_sre(u32 val)

{

	asm volatile("msr_s " __stringify(ICC_SRE_EL1) ", %0" : : "r" (val));

	asm volatile("msr_s " __stringify(ICC_SRE_EL1) ", %0" : : "r" ((u64)val));

	isb();

}

drivers/irqchip/irq-gic-v3.c

+12 −13
Original line number Diff line number Diff line
@@ -319,11 +319,11 @@ static int gic_irq_set_vcpu_affinity(struct irq_data *d, void *vcpu) 
	return 0;

}



static u64 gic_mpidr_to_affinity(u64 mpidr)

static u64 gic_mpidr_to_affinity(unsigned long mpidr)

{

	u64 aff;



	aff = (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 |

	aff = ((u64)MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 |

	       MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 |

	       MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8  |

	       MPIDR_AFFINITY_LEVEL(mpidr, 0));
@@ -333,7 +333,7 @@ static u64 gic_mpidr_to_affinity(u64 mpidr) 


static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs)

{

	u64 irqnr;

	u32 irqnr;



	do {

		irqnr = gic_read_iar();
@@ -397,7 +397,7 @@ static void __init gic_dist_init(void) 


static int gic_populate_rdist(void)

{

	u64 mpidr = cpu_logical_map(smp_processor_id());

	unsigned long mpidr = cpu_logical_map(smp_processor_id());

	u64 typer;

	u32 aff;

	int i;
@@ -428,10 +428,9 @@ static int gic_populate_rdist(void) 
				u64 offset = ptr - gic_data.redist_regions[i].redist_base;

				gic_data_rdist_rd_base() = ptr;

				gic_data_rdist()->phys_base = gic_data.redist_regions[i].phys_base + offset;

				pr_info("CPU%d: found redistributor %llx region %d:%pa\n",

					smp_processor_id(),

					(unsigned long long)mpidr,

					i, &gic_data_rdist()->phys_base);

				pr_info("CPU%d: found redistributor %lx region %d:%pa\n",

					smp_processor_id(), mpidr, i,

					&gic_data_rdist()->phys_base);

				return 0;

			}
@@ -446,8 +445,8 @@ static int gic_populate_rdist(void) 
	}



	/* We couldn't even deal with ourselves... */

	WARN(true, "CPU%d: mpidr %llx has no re-distributor!\n",

	     smp_processor_id(), (unsigned long long)mpidr);

	WARN(true, "CPU%d: mpidr %lx has no re-distributor!\n",

	     smp_processor_id(), mpidr);

	return -ENODEV;

}
@@ -524,10 +523,10 @@ static struct notifier_block gic_cpu_notifier = { 
};



static u16 gic_compute_target_list(int *base_cpu, const struct cpumask *mask,

				   u64 cluster_id)

				   unsigned long cluster_id)

{

	int cpu = *base_cpu;

	u64 mpidr = cpu_logical_map(cpu);

	unsigned long mpidr = cpu_logical_map(cpu);

	u16 tlist = 0;



	while (cpu < nr_cpu_ids) {
@@ -588,7 +587,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq) 
	smp_wmb();



	for_each_cpu(cpu, mask) {

		u64 cluster_id = cpu_logical_map(cpu) & ~0xffUL;

		unsigned long cluster_id = cpu_logical_map(cpu) & ~0xffUL;

		u16 tlist;



		tlist = gic_compute_target_list(&cpu, mask, cluster_id);

include/linux/irqchip/arm-gic-v3.h

+9 −9
Original line number Diff line number Diff line
@@ -265,16 +265,16 @@ 
/*

 * Hypervisor interface registers (SRE only)

 */

#define ICH_LR_VIRTUAL_ID_MASK		((1UL << 32) - 1)



#define ICH_LR_EOI			(1UL << 41)

#define ICH_LR_GROUP			(1UL << 60)

#define ICH_LR_HW			(1UL << 61)

#define ICH_LR_STATE			(3UL << 62)

#define ICH_LR_PENDING_BIT		(1UL << 62)

#define ICH_LR_ACTIVE_BIT		(1UL << 63)

#define ICH_LR_VIRTUAL_ID_MASK		((1ULL << 32) - 1)



#define ICH_LR_EOI			(1ULL << 41)

#define ICH_LR_GROUP			(1ULL << 60)

#define ICH_LR_HW			(1ULL << 61)

#define ICH_LR_STATE			(3ULL << 62)

#define ICH_LR_PENDING_BIT		(1ULL << 62)

#define ICH_LR_ACTIVE_BIT		(1ULL << 63)

#define ICH_LR_PHYS_ID_SHIFT		32

#define ICH_LR_PHYS_ID_MASK		(0x3ffUL << ICH_LR_PHYS_ID_SHIFT)

#define ICH_LR_PHYS_ID_MASK		(0x3ffULL << ICH_LR_PHYS_ID_SHIFT)



#define ICH_MISR_EOI			(1 << 0)

#define ICH_MISR_U			(1 << 1)

CRA Git | Maintained and supported by SUSTech CRA and CCSE