usb: dwc3: gadget: loop while (timeout) (f6bb225b) · Commits · 戴 / test

instead of having infinite loop and always checking timeout value as a break condition, we can just decrement timeout inside while's condition. Signed-off-by:

Felipe Balbi <felipe.balbi@linux.intel.com>

drivers/usb/dwc3/gadget.c

+6 −12

Original line number	Diff line number	Diff line
		@@ -327,19 +327,13 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd,

		break;
		}
		} while (--timeout);

		/*
		* We can't sleep here, because it is also called from
		* interrupt context.
		*/
		timeout--;
		if (!timeout) {
		if (timeout == 0) {
		dwc3_trace(trace_dwc3_gadget,
		"Command Timed Out");
		ret = -ETIMEDOUT;
		break;
		}
		} while (1);

		if (unlikely(susphy)) {
		reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0));

Admin message