Commit f6b6a28e authored Jul 29, 2016 by Gabriel Krisman Bertazi Committed by Jens Axboe Aug 15, 2016

nvme: Prevent controller state invalid transition



Acquiring the nvme_ctrl lock before reading ctrl->state in
nvme_change_ctrl_state() should prevent a theoretical invalid state
transition, in the event of two threads racing inside that function.

I haven't been able to observe this happening with the current code, and
the current state machine seems to be simple enough to not be
affected by these invalid transitions, but future modifications could
make it more likely to happen.

Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Reviewed-by: Sagi Grimberg <sag@grimberg.me>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 694d0d0b

drivers/nvme/host/core.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -81,10 +81,12 @@ EXPORT_SYMBOL_GPL(nvme_cancel_request);
		bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
		enum nvme_ctrl_state new_state)
		{
		enum nvme_ctrl_state old_state = ctrl->state;
		enum nvme_ctrl_state old_state;
		bool changed = false;

		spin_lock_irq(&ctrl->lock);

		old_state = ctrl->state;
		switch (new_state) {
		case NVME_CTRL_LIVE:
		switch (old_state) {
		@@ -140,11 +142,12 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
		default:
		break;
		}
		spin_unlock_irq(&ctrl->lock);

		if (changed)
		ctrl->state = new_state;

		spin_unlock_irq(&ctrl->lock);

		return changed;
		}
		EXPORT_SYMBOL_GPL(nvme_change_ctrl_state);

Admin message