Commit f6b66314 authored Apr 20, 2018 by Hans Verkuil Committed by Mauro Carvalho Chehab May 09, 2018

media: cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN



This driver needs a pull up output GPIO, but devm_gpiod_get() is called
with GPIOD_IN. This apparently works fine for the RPi3 where the DT
correctly specifies a pull up GPIO, but on the i.MX6 it also needs to
be specified with devm_gpiod_get().

Reported-by: Henrik Mau <Henrik.Mau@linn.co.uk>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 8516529e

drivers/media/platform/cec-gpio/cec-gpio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -158,7 +158,7 @@ static int cec_gpio_probe(struct platform_device *pdev)

		cec->dev = dev;

		cec->cec_gpio = devm_gpiod_get(dev, "cec", GPIOD_IN);
		cec->cec_gpio = devm_gpiod_get(dev, "cec", GPIOD_OUT_HIGH_OPEN_DRAIN);
		if (IS_ERR(cec->cec_gpio))
		return PTR_ERR(cec->cec_gpio);
		cec->cec_irq = gpiod_to_irq(cec->cec_gpio);

Admin message