Commit f6ac8585 authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso
Browse files

netfilter: nf_tables: unbind set in rule from commit path 



Anonymous sets that are bound to rules from the same transaction trigger
a kernel splat from the abort path due to double set list removal and
double free.

This patch updates the logic to search for the transaction that is
responsible for creating the set and disable the set list removal and
release, given the rule is now responsible for this. Lookup is reverse
since the transaction that adds the set is likely to be at the tail of
the list.

Moreover, this patch adds the unbind step to deliver the event from the
commit path.  This should not be done from the worker thread, since we
have no guarantees of in-order delivery to the listener.

This patch removes the assumption that both activate and deactivate
callbacks need to be provided.

Fixes: cd5125d8 ("netfilter: nf_tables: split set destruction in deactivate and destroy phase")
Reported-by: default avatarMikhail Morfikov <mmorfikov@gmail.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 4e35c1cb

include/net/netfilter/nf_tables.h

+13 −4
Original line number Diff line number Diff line
@@ -469,9 +469,7 @@ struct nft_set_binding { 
int nf_tables_bind_set(const struct nft_ctx *ctx, struct nft_set *set,

		       struct nft_set_binding *binding);

void nf_tables_unbind_set(const struct nft_ctx *ctx, struct nft_set *set,

			  struct nft_set_binding *binding);

void nf_tables_rebind_set(const struct nft_ctx *ctx, struct nft_set *set,

			  struct nft_set_binding *binding);

			  struct nft_set_binding *binding, bool commit);

void nf_tables_destroy_set(const struct nft_ctx *ctx, struct nft_set *set);



/**
@@ -721,6 +719,13 @@ struct nft_expr_type { 
#define NFT_EXPR_STATEFUL		0x1

#define NFT_EXPR_GC			0x2



enum nft_trans_phase {

	NFT_TRANS_PREPARE,

	NFT_TRANS_ABORT,

	NFT_TRANS_COMMIT,

	NFT_TRANS_RELEASE

};



/**

 *	struct nft_expr_ops - nf_tables expression operations

 *
@@ -750,7 +755,8 @@ struct nft_expr_ops { 
	void				(*activate)(const struct nft_ctx *ctx,

						    const struct nft_expr *expr);

	void				(*deactivate)(const struct nft_ctx *ctx,

						      const struct nft_expr *expr);

						      const struct nft_expr *expr,

						      enum nft_trans_phase phase);

	void				(*destroy)(const struct nft_ctx *ctx,

						   const struct nft_expr *expr);

	void				(*destroy_clone)(const struct nft_ctx *ctx,
@@ -1323,12 +1329,15 @@ struct nft_trans_rule { 
struct nft_trans_set {

	struct nft_set			*set;

	u32				set_id;

	bool				bound;

};



#define nft_trans_set(trans)	\

	(((struct nft_trans_set *)trans->data)->set)

#define nft_trans_set_id(trans)	\

	(((struct nft_trans_set *)trans->data)->set_id)

#define nft_trans_set_bound(trans)	\

	(((struct nft_trans_set *)trans->data)->bound)



struct nft_trans_chain {

	bool				update;

net/netfilter/nf_tables_api.c

+41 −44
Original line number Diff line number Diff line
@@ -116,6 +116,23 @@ static void nft_trans_destroy(struct nft_trans *trans) 
	kfree(trans);

}



static void nft_set_trans_bind(const struct nft_ctx *ctx, struct nft_set *set)

{

	struct net *net = ctx->net;

	struct nft_trans *trans;



	if (!nft_set_is_anonymous(set))

		return;



	list_for_each_entry_reverse(trans, &net->nft.commit_list, list) {

		if (trans->msg_type == NFT_MSG_NEWSET &&

		    nft_trans_set(trans) == set) {

			nft_trans_set_bound(trans) = true;

			break;

		}

	}

}



static int nf_tables_register_hook(struct net *net,

				   const struct nft_table *table,

				   struct nft_chain *chain)
@@ -211,18 +228,6 @@ static int nft_delchain(struct nft_ctx *ctx) 
	return err;

}



/* either expr ops provide both activate/deactivate, or neither */

static bool nft_expr_check_ops(const struct nft_expr_ops *ops)

{

	if (!ops)

		return true;



	if (WARN_ON_ONCE((!ops->activate ^ !ops->deactivate)))

		return false;



	return true;

}



static void nft_rule_expr_activate(const struct nft_ctx *ctx,

				   struct nft_rule *rule)

{
@@ -238,14 +243,15 @@ static void nft_rule_expr_activate(const struct nft_ctx *ctx, 
}



static void nft_rule_expr_deactivate(const struct nft_ctx *ctx,

				     struct nft_rule *rule)

				     struct nft_rule *rule,

				     enum nft_trans_phase phase)

{

	struct nft_expr *expr;



	expr = nft_expr_first(rule);

	while (expr != nft_expr_last(rule) && expr->ops) {

		if (expr->ops->deactivate)

			expr->ops->deactivate(ctx, expr);

			expr->ops->deactivate(ctx, expr, phase);



		expr = nft_expr_next(expr);

	}
@@ -296,7 +302,7 @@ static int nft_delrule(struct nft_ctx *ctx, struct nft_rule *rule) 
		nft_trans_destroy(trans);

		return err;

	}

	nft_rule_expr_deactivate(ctx, rule);

	nft_rule_expr_deactivate(ctx, rule, NFT_TRANS_PREPARE);



	return 0;

}
@@ -1929,9 +1935,6 @@ static int nf_tables_delchain(struct net *net, struct sock *nlsk, 
 */

int nft_register_expr(struct nft_expr_type *type)

{

	if (!nft_expr_check_ops(type->ops))

		return -EINVAL;



	nfnl_lock(NFNL_SUBSYS_NFTABLES);

	if (type->family == NFPROTO_UNSPEC)

		list_add_tail_rcu(&type->list, &nf_tables_expressions);
@@ -2079,10 +2082,6 @@ static int nf_tables_expr_parse(const struct nft_ctx *ctx, 
			err = PTR_ERR(ops);

			goto err1;

		}

		if (!nft_expr_check_ops(ops)) {

			err = -EINVAL;

			goto err1;

		}

	} else

		ops = type->ops;
@@ -2511,7 +2510,7 @@ static void nf_tables_rule_destroy(const struct nft_ctx *ctx, 
static void nf_tables_rule_release(const struct nft_ctx *ctx,

				   struct nft_rule *rule)

{

	nft_rule_expr_deactivate(ctx, rule);

	nft_rule_expr_deactivate(ctx, rule, NFT_TRANS_RELEASE);

	nf_tables_rule_destroy(ctx, rule);

}
@@ -3708,40 +3707,31 @@ int nf_tables_bind_set(const struct nft_ctx *ctx, struct nft_set *set, 
bind:

	binding->chain = ctx->chain;

	list_add_tail_rcu(&binding->list, &set->bindings);

	nft_set_trans_bind(ctx, set);



	return 0;

}

EXPORT_SYMBOL_GPL(nf_tables_bind_set);



void nf_tables_rebind_set(const struct nft_ctx *ctx, struct nft_set *set,

			  struct nft_set_binding *binding)

{

	if (list_empty(&set->bindings) && nft_set_is_anonymous(set) &&

	    nft_is_active(ctx->net, set))

		list_add_tail_rcu(&set->list, &ctx->table->sets);



	list_add_tail_rcu(&binding->list, &set->bindings);

}

EXPORT_SYMBOL_GPL(nf_tables_rebind_set);



void nf_tables_unbind_set(const struct nft_ctx *ctx, struct nft_set *set,

		          struct nft_set_binding *binding)

			  struct nft_set_binding *binding, bool event)

{

	list_del_rcu(&binding->list);



	if (list_empty(&set->bindings) && nft_set_is_anonymous(set) &&

	    nft_is_active(ctx->net, set))

	if (list_empty(&set->bindings) && nft_set_is_anonymous(set)) {

		list_del_rcu(&set->list);

		if (event)

			nf_tables_set_notify(ctx, set, NFT_MSG_DELSET,

					     GFP_KERNEL);

	}

}

EXPORT_SYMBOL_GPL(nf_tables_unbind_set);



void nf_tables_destroy_set(const struct nft_ctx *ctx, struct nft_set *set)

{

	if (list_empty(&set->bindings) && nft_set_is_anonymous(set) &&

	    nft_is_active(ctx->net, set)) {

		nf_tables_set_notify(ctx, set, NFT_MSG_DELSET, GFP_ATOMIC);

	if (list_empty(&set->bindings) && nft_set_is_anonymous(set))

		nft_set_destroy(set);

}

}

EXPORT_SYMBOL_GPL(nf_tables_destroy_set);



const struct nft_set_ext_type nft_set_ext_types[] = {
@@ -6535,6 +6525,9 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb) 
			nf_tables_rule_notify(&trans->ctx,

					      nft_trans_rule(trans),

					      NFT_MSG_DELRULE);

			nft_rule_expr_deactivate(&trans->ctx,

						 nft_trans_rule(trans),

						 NFT_TRANS_COMMIT);

			break;

		case NFT_MSG_NEWSET:

			nft_clear(net, nft_trans_set(trans));
@@ -6621,6 +6614,7 @@ static void nf_tables_abort_release(struct nft_trans *trans) 
		nf_tables_rule_destroy(&trans->ctx, nft_trans_rule(trans));

		break;

	case NFT_MSG_NEWSET:

		if (!nft_trans_set_bound(trans))

			nft_set_destroy(nft_trans_set(trans));

		break;

	case NFT_MSG_NEWSETELEM:
@@ -6682,7 +6676,9 @@ static int __nf_tables_abort(struct net *net) 
		case NFT_MSG_NEWRULE:

			trans->ctx.chain->use--;

			list_del_rcu(&nft_trans_rule(trans)->list);

			nft_rule_expr_deactivate(&trans->ctx, nft_trans_rule(trans));

			nft_rule_expr_deactivate(&trans->ctx,

						 nft_trans_rule(trans),

						 NFT_TRANS_ABORT);

			break;

		case NFT_MSG_DELRULE:

			trans->ctx.chain->use++;
@@ -6692,6 +6688,7 @@ static int __nf_tables_abort(struct net *net) 
			break;

		case NFT_MSG_NEWSET:

			trans->ctx.table->use--;

			if (!nft_trans_set_bound(trans))

				list_del_rcu(&nft_trans_set(trans)->list);

			break;

		case NFT_MSG_DELSET:

net/netfilter/nft_compat.c

+5 −1
Original line number Diff line number Diff line
@@ -587,10 +587,14 @@ static void nft_compat_activate_tg(const struct nft_ctx *ctx, 
}



static void nft_compat_deactivate(const struct nft_ctx *ctx,

				  const struct nft_expr *expr)

				  const struct nft_expr *expr,

				  enum nft_trans_phase phase)

{

	struct nft_xt *xt = container_of(expr->ops, struct nft_xt, ops);



	if (phase == NFT_TRANS_COMMIT)

		return;



	if (--xt->listcnt == 0)

		list_del_init(&xt->head);

}

net/netfilter/nft_dynset.c

+7 −11
Original line number Diff line number Diff line
@@ -235,20 +235,17 @@ err1: 
	return err;

}



static void nft_dynset_activate(const struct nft_ctx *ctx,

				const struct nft_expr *expr)

{

	struct nft_dynset *priv = nft_expr_priv(expr);



	nf_tables_rebind_set(ctx, priv->set, &priv->binding);

}



static void nft_dynset_deactivate(const struct nft_ctx *ctx,

				  const struct nft_expr *expr)

				  const struct nft_expr *expr,

				  enum nft_trans_phase phase)

{

	struct nft_dynset *priv = nft_expr_priv(expr);



	nf_tables_unbind_set(ctx, priv->set, &priv->binding);

	if (phase == NFT_TRANS_PREPARE)

		return;



	nf_tables_unbind_set(ctx, priv->set, &priv->binding,

			     phase == NFT_TRANS_COMMIT);

}



static void nft_dynset_destroy(const struct nft_ctx *ctx,
@@ -296,7 +293,6 @@ static const struct nft_expr_ops nft_dynset_ops = { 
	.eval		= nft_dynset_eval,

	.init		= nft_dynset_init,

	.destroy	= nft_dynset_destroy,

	.activate	= nft_dynset_activate,

	.deactivate	= nft_dynset_deactivate,

	.dump		= nft_dynset_dump,

};

net/netfilter/nft_immediate.c

+5 −1
Original line number Diff line number Diff line
@@ -72,10 +72,14 @@ static void nft_immediate_activate(const struct nft_ctx *ctx, 
}



static void nft_immediate_deactivate(const struct nft_ctx *ctx,

				     const struct nft_expr *expr)

				     const struct nft_expr *expr,

				     enum nft_trans_phase phase)

{

	const struct nft_immediate_expr *priv = nft_expr_priv(expr);



	if (phase == NFT_TRANS_COMMIT)

		return;



	return nft_data_release(&priv->data, nft_dreg_to_type(priv->dreg));

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE