Commit f6a447fa authored Aug 30, 2018 by Aapo Vienamo Committed by Ulf Hansson Oct 08, 2018

mmc: tegra: Remove tegra_sdhci_writew() from tegra210_sdhci_ops

tegra_sdhci_writew() defers the write to SDHCI_TRANSFER_MODE until
SDHCI_COMMAND is written. This is not necessary on Tegra210 and Tegra186
and it breaks read-modify-write operations on SDHCI_TRANSFER_MODE
because writes to SDHCI_TRANSFER_MODE aren't visible until SDHCI_COMMAND
has been written to. This results in tuning failures on Tegra210.

Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 1070e83a

drivers/mmc/host/sdhci-tegra.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -834,7 +834,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra124 = {
		static const struct sdhci_ops tegra210_sdhci_ops = {
		.get_ro = tegra_sdhci_get_ro,
		.read_w = tegra_sdhci_readw,
		.write_w = tegra_sdhci_writew,
		.write_l = tegra_sdhci_writel,
		.set_clock = tegra_sdhci_set_clock,
		.set_bus_width = sdhci_set_bus_width,

Admin message