mmc: block: fix debugfs_simple_attr.cocci warnings (f6a3d9d9) · Commits · 戴 / test

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Signed-off-by:

Ulf Hansson <ulf.hansson@linaro.org>

drivers/mmc/core/block.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -2774,7 +2774,7 @@ static int mmc_dbg_card_status_get(void data, u64 val)

		return ret;
		}
		DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get,
		DEFINE_DEBUGFS_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get,
		NULL, "%08llx\n");

		/* That is two digits * 512 + 1 for newline */
		@@ -2863,7 +2863,8 @@ static int mmc_blk_add_debugfs(struct mmc_card card, struct mmc_blk_data md)

		if (mmc_card_mmc(card) \|\| mmc_card_sd(card)) {
		md->status_dentry =
		debugfs_create_file("status", S_IRUSR, root, card,
		debugfs_create_file_unsafe("status", 0400, root,
		card,
		&mmc_dbg_card_status_fops);
		if (!md->status_dentry)
		return -EIO;

Admin message