Commit f69115fd authored by Mathias Nyman's avatar Mathias Nyman Committed by Greg Kroah-Hartman
Browse files

xhci: fix usb2 resume timing and races. 



According to USB 2 specs ports need to signal resume for at least 20ms,
in practice even longer, before moving to U0 state.
Both host and devices can initiate resume.

On device initiated resume, a port status interrupt with the port in resume
state in issued. The interrupt handler tags a resume_done[port]
timestamp with current time + USB_RESUME_TIMEOUT, and kick roothub timer.
Root hub timer requests for port status, finds the port in resume state,
checks if resume_done[port] timestamp passed, and set port to U0 state.

On host initiated resume, current code sets the port to resume state,
sleep 20ms, and finally sets the port to U0 state. This should also
be changed to work in a similar way as the device initiated resume, with
timestamp tagging, but that is not yet tested and will be a separate
fix later.

There are a few issues with this approach

1. A host initiated resume will also generate a resume event. The event
   handler will find the port in resume state, believe it's a device
   initiated resume, and act accordingly.

2. A port status request might cut the resume signalling short if a
   get_port_status request is handled during the host resume signalling.
   The port will be found in resume state. The timestamp is not set leading
   to time_after_eq(jiffies, timestamp) returning true, as timestamp = 0.
   get_port_status will proceed with moving the port to U0.

3. If an error, or anything else happens to the port during device
   initiated resume signalling it will leave all the device resume
   parameters hanging uncleared, preventing further suspend, returning
   -EBUSY, and cause the pm thread to busyloop trying to enter suspend.

Fix this by using the existing resuming_ports bitfield to indicate that
resume signalling timing is taken care of.
Check if the resume_done[port] is set before using it for timestamp
comparison, and also clear out any resume signalling related variables
if port is not in U0 or Resume state

This issue was discovered when a PM thread busylooped, trying to runtime
suspend the xhci USB 2 roothub on a Dell XPS

Cc: stable <stable@vger.kernel.org>
Reported-by: default avatarDaniel J Blueman <daniel@quora.org>
Tested-by: default avatarDaniel J Blueman <daniel@quora.org>
Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 73b39bb0

drivers/usb/host/xhci-hub.c

+42 −5
Original line number Diff line number Diff line
@@ -733,7 +733,29 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd, 
		if ((raw_port_status & PORT_RESET) ||

				!(raw_port_status & PORT_PE))

			return 0xffffffff;

		if (time_after_eq(jiffies,

		/* did port event handler already start resume timing? */

		if (!bus_state->resume_done[wIndex]) {

			/* If not, maybe we are in a host initated resume? */

			if (test_bit(wIndex, &bus_state->resuming_ports)) {

				/* Host initated resume doesn't time the resume

				 * signalling using resume_done[].

				 * It manually sets RESUME state, sleeps 20ms

				 * and sets U0 state. This should probably be

				 * changed, but not right now.

				 */

			} else {

				/* port resume was discovered now and here,

				 * start resume timing

				 */

				unsigned long timeout = jiffies +

					msecs_to_jiffies(USB_RESUME_TIMEOUT);



				set_bit(wIndex, &bus_state->resuming_ports);

				bus_state->resume_done[wIndex] = timeout;

				mod_timer(&hcd->rh_timer, timeout);

			}

		/* Has resume been signalled for USB_RESUME_TIME yet? */

		} else if (time_after_eq(jiffies,

					 bus_state->resume_done[wIndex])) {

			int time_left;
@@ -775,13 +797,26 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd, 
		} else {

			/*

			 * The resume has been signaling for less than

			 * 20ms. Report the port status as SUSPEND,

			 * let the usbcore check port status again

			 * and clear resume signaling later.

			 * USB_RESUME_TIME. Report the port status as SUSPEND,

			 * let the usbcore check port status again and clear

			 * resume signaling later.

			 */

			status |= USB_PORT_STAT_SUSPEND;

		}

	}

	/*

	 * Clear stale usb2 resume signalling variables in case port changed

	 * state during resume signalling. For example on error

	 */

	if ((bus_state->resume_done[wIndex] ||

	     test_bit(wIndex, &bus_state->resuming_ports)) &&

	    (raw_port_status & PORT_PLS_MASK) != XDEV_U3 &&

	    (raw_port_status & PORT_PLS_MASK) != XDEV_RESUME) {

		bus_state->resume_done[wIndex] = 0;

		clear_bit(wIndex, &bus_state->resuming_ports);

	}





	if ((raw_port_status & PORT_PLS_MASK) == XDEV_U0 &&

	    (raw_port_status & PORT_POWER)) {

		if (bus_state->suspended_ports & (1 << wIndex)) {
@@ -1115,6 +1150,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, 
				if ((temp & PORT_PE) == 0)

					goto error;



				set_bit(wIndex, &bus_state->resuming_ports);

				xhci_set_link_state(xhci, port_array, wIndex,

							XDEV_RESUME);

				spin_unlock_irqrestore(&xhci->lock, flags);
@@ -1122,6 +1158,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, 
				spin_lock_irqsave(&xhci->lock, flags);

				xhci_set_link_state(xhci, port_array, wIndex,

							XDEV_U0);

				clear_bit(wIndex, &bus_state->resuming_ports);

			}

			bus_state->port_c_suspend |= 1 << wIndex;

drivers/usb/host/xhci-ring.c

+2 −1
Original line number Diff line number Diff line
@@ -1583,7 +1583,8 @@ static void handle_port_status(struct xhci_hcd *xhci, 
			 */

			bogus_port_status = true;

			goto cleanup;

		} else {

		} else if (!test_bit(faked_port_index,

				     &bus_state->resuming_ports)) {

			xhci_dbg(xhci, "resume HS port %d\n", port_id);

			bus_state->resume_done[faked_port_index] = jiffies +

				msecs_to_jiffies(USB_RESUME_TIMEOUT);

CRA Git | Maintained and supported by SUSTech CRA and CCSE