Commit f6824308 authored Oct 21, 2019 by Vasundhara Volam Committed by Jakub Kicinski Oct 22, 2019

bnxt_en: Avoid disabling pci device in bnxt_remove_one() for already disabled device.



With the recently added error recovery logic, the device may already
be disabled if the firmware recovery is unsuccessful.  In
bnxt_remove_one(), check that the device is still enabled first
before calling pci_disable_device().

Fixes: 3bc7d4a3 ("bnxt_en: Add BNXT_STATE_IN_FW_RESET state.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

parent f255ed1c

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -10382,6 +10382,7 @@ static void bnxt_cleanup_pci(struct bnxt *bp)
		{
		bnxt_unmap_bars(bp, bp->pdev);
		pci_release_regions(bp->pdev);
		if (pci_is_enabled(bp->pdev))
		pci_disable_device(bp->pdev);
		}

Admin message