Commit f6735590 authored May 27, 2010 by Linus Torvalds Committed by Jesse Barnes Jul 30, 2010

PCI aerdrv: fix annoying warnings



Some compiler generates following warnings:

  In function 'aer_isr':
  warning: 'e_src.id' may be used uninitialized in this function
  warning: 'e_src.status' may be used uninitialized in this function

Avoid status flag "int ret" and return constants instead, so that
gcc sees the return value matching "it is initialized" better.

Acked-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent 73cd3b43

drivers/pci/pcie/aer/aerdrv_core.c

+9 −8

Original line number	Diff line number	Diff line
		@@ -727,20 +727,21 @@ static void aer_isr_one_error(struct pcie_device *p_device,
		static int get_e_source(struct aer_rpc rpc, struct aer_err_source e_src)
		{
		unsigned long flags;
		int ret = 0;

		/* Lock access to Root error producer/consumer index */
		spin_lock_irqsave(&rpc->e_lock, flags);
		if (rpc->prod_idx != rpc->cons_idx) {
		if (rpc->prod_idx == rpc->cons_idx) {
		spin_unlock_irqrestore(&rpc->e_lock, flags);
		return 0;
		}

		*e_src = rpc->e_sources[rpc->cons_idx];
		rpc->cons_idx++;
		if (rpc->cons_idx == AER_ERROR_SOURCES_MAX)
		rpc->cons_idx = 0;
		ret = 1;
		}
		spin_unlock_irqrestore(&rpc->e_lock, flags);

		return ret;
		return 1;
		}

		/**

Admin message