Commit f6521c58 authored Jun 03, 2018 by Paul Blakey Committed by David S. Miller Jun 04, 2018

cls_flower: Fix comparing of old filter mask with new filter



We incorrectly compare the mask and the result is that we can't modify
an already existing rule.

Fix that by comparing correctly.

Fixes: 05cd271f ("cls_flower: Support multiple masks per priority")
Reported-by: Vlad Buslov <vladbu@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Paul Blakey <paulb@mellanox.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent de9dc650

net/sched/cls_flower.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -877,7 +877,7 @@ static int fl_check_assign_mask(struct cls_fl_head *head,
		return PTR_ERR(newmask);

		fnew->mask = newmask;
		} else if (fold && fold->mask == fnew->mask) {
		} else if (fold && fold->mask != fnew->mask) {
		return -EINVAL;
		}

Admin message