Commit f6419f24 authored by Lorenzo Pieralisi's avatar Lorenzo Pieralisi Committed by Russell King
Browse files

ARM: 8485/1: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook 



The suspend() hook in the cpuidle_ops struct is always called on
the cpu entering idle, which means that the cpu parameter passed
to the suspend hook always corresponds to the local cpu, making
it somewhat redundant.

This patch removes the logical cpu parameter from the ARM
cpuidle_ops.suspend hook and updates all the existing kernel
implementations to reflect this change.

Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: default avatarLina Iyer <lina.iyer@linaro.org>
Tested-by: default avatarLina Iyer <lina.iyer@linaro.org>
Tested-by: Jisheng Zhang <jszhang@marvell.com> [psci]
Cc: Lina Iyer <lina.iyer@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 42f25bdd

arch/arm/include/asm/cpuidle.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -30,7 +30,7 @@ static inline int arm_cpuidle_simple_enter(struct cpuidle_device *dev, 
struct device_node;

struct device_node;





struct cpuidle_ops {

struct cpuidle_ops {

	int (*suspend)(int cpu, unsigned long arg);

	int (*suspend)(unsigned long arg);

	int (*init)(struct device_node *, int cpu);

	int (*init)(struct device_node *, int cpu);

};

};

arch/arm/kernel/cpuidle.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -56,7 +56,7 @@ int arm_cpuidle_suspend(int index) 
	int cpu = smp_processor_id();

	int cpu = smp_processor_id();





	if (cpuidle_ops[cpu].suspend)

	if (cpuidle_ops[cpu].suspend)

		ret = cpuidle_ops[cpu].suspend(cpu, index);

		ret = cpuidle_ops[cpu].suspend(index);





	return ret;

	return ret;

}

}

drivers/soc/qcom/spm.c

+5 −5
Original line number Original line Diff line number Diff line
@@ -116,7 +116,7 @@ static const struct spm_reg_data spm_reg_8064_cpu = { 




static DEFINE_PER_CPU(struct spm_driver_data *, cpu_spm_drv);

static DEFINE_PER_CPU(struct spm_driver_data *, cpu_spm_drv);





typedef int (*idle_fn)(int);

typedef int (*idle_fn)(void);

static DEFINE_PER_CPU(idle_fn*, qcom_idle_ops);

static DEFINE_PER_CPU(idle_fn*, qcom_idle_ops);





static inline void spm_register_write(struct spm_driver_data *drv,

static inline void spm_register_write(struct spm_driver_data *drv,
@@ -179,10 +179,10 @@ static int qcom_pm_collapse(unsigned long int unused) 
	return -1;

	return -1;

}

}





static int qcom_cpu_spc(int cpu)

static int qcom_cpu_spc(void)

{

{

	int ret;

	int ret;

	struct spm_driver_data *drv = per_cpu(cpu_spm_drv, cpu);

	struct spm_driver_data *drv = __this_cpu_read(cpu_spm_drv);





	spm_set_low_power_mode(drv, PM_SLEEP_MODE_SPC);

	spm_set_low_power_mode(drv, PM_SLEEP_MODE_SPC);

	ret = cpu_suspend(0, qcom_pm_collapse);

	ret = cpu_suspend(0, qcom_pm_collapse);
@@ -197,9 +197,9 @@ static int qcom_cpu_spc(int cpu) 
	return ret;

	return ret;

}

}





static int qcom_idle_enter(int cpu, unsigned long index)

static int qcom_idle_enter(unsigned long index)

{

{

	return per_cpu(qcom_idle_ops, cpu)[index](cpu);

	return __this_cpu_read(qcom_idle_ops)[index]();

}

}





static const struct of_device_id qcom_idle_state_match[] __initconst = {

static const struct of_device_id qcom_idle_state_match[] __initconst = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE