Commit f601e8f3 authored Sep 09, 2020 by Greg Kroah-Hartman

Revert "driver core: Annotate dev_err_probe() with __must_check"



This reverts commit e1f82a0d as it's
already starting to cause build warnings in linux-next for things that
are "obviously correct".

It's up to driver authors do "do the right thing" here with this
function, and if they don't want to call it as the last line of a
function, that's up to them, otherwise code that looks like:
	ret = dev_err_probe(..., ret, ...);
does look really "odd".

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Fixes: e1f82a0d ("driver core: Annotate dev_err_probe() with __must_check")
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7c69898b

include/linux/device.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -924,7 +924,7 @@ void device_links_supplier_sync_state_pause(void);
		void device_links_supplier_sync_state_resume(void);

		extern __printf(3, 4)
		int __must_check dev_err_probe(const struct device dev, int err, const char fmt, ...);
		int dev_err_probe(const struct device dev, int err, const char fmt, ...);

		/* Create alias, so I can be autoloaded. */
		#define MODULE_ALIAS_CHARDEV(major,minor) \

Admin message