Commit f5edbe77 authored by Sreekanth Reddy's avatar Sreekanth Reddy Committed by James Bottomley
Browse files

[SCSI] mpt3sas: when async scanning is enabled then while scanning, devices... 


[SCSI] mpt3sas: when async scanning is enabled then while scanning, devices are removed but their transport layer entries are not removed

When Async scanning mode is enabled and device scanning is in progress,
devices should not be removed. But in actuality, devices are removed but
their transport layer entries are not removed. This causes error to add
the same device to the transport layer after host reset or diagnostic
reset.

So, in this patch, modified the code in such a way that device is not removed
when Async scanning mode is enabled and device scanning is in progress.

Signed-off-by: default avatarSreekanth Reddy <Sreekanth.Reddy@lsi.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 17263e75

drivers/scsi/mpt3sas/mpt3sas_scsih.c

+13 −9
Original line number Diff line number Diff line
@@ -675,13 +675,14 @@ _scsih_sas_device_add(struct MPT3SAS_ADAPTER *ioc, 
		 * devices while scanning is turned on due to an oops in

		 * scsi_sysfs_add_sdev()->add_device()->sysfs_addrm_start()

		 */

		if (!ioc->is_driver_loading)

		if (!ioc->is_driver_loading) {

			mpt3sas_transport_port_remove(ioc,

			    sas_device->sas_address,

			    sas_device->sas_address_parent);

			_scsih_sas_device_remove(ioc, sas_device);

		}

	}

}



/**

 * _scsih_sas_device_init_add - insert sas_device to the list.
@@ -7531,13 +7532,15 @@ _scsih_probe_boot_devices(struct MPT3SAS_ADAPTER *ioc) 
		    sas_address_parent)) {

			_scsih_sas_device_remove(ioc, sas_device);

		} else if (!sas_device->starget) {

			if (!ioc->is_driver_loading)

				mpt3sas_transport_port_remove(ioc, sas_address,

			if (!ioc->is_driver_loading) {

				mpt3sas_transport_port_remove(ioc,

				    sas_address,

				    sas_address_parent);

				_scsih_sas_device_remove(ioc, sas_device);

			}

		}

	}

}



/**

 * _scsih_probe_raid - reporting raid volumes to scsi-ml
@@ -7590,7 +7593,7 @@ _scsih_probe_sas(struct MPT3SAS_ADAPTER *ioc) 
			 * oops in scsi_sysfs_add_sdev()->add_device()->

			 * sysfs_addrm_start()

			 */

			if (!ioc->is_driver_loading)

			if (!ioc->is_driver_loading) {

				mpt3sas_transport_port_remove(ioc,

				    sas_device->sas_address,

				    sas_device->sas_address_parent);
@@ -7598,6 +7601,7 @@ _scsih_probe_sas(struct MPT3SAS_ADAPTER *ioc) 
				kfree(sas_device);

				continue;

			}

		}



		spin_lock_irqsave(&ioc->sas_device_lock, flags);

		list_move_tail(&sas_device->list, &ioc->sas_device_list);

CRA Git | Maintained and supported by SUSTech CRA and CCSE