Commit f5e6d0d0 authored by Aaron Lu's avatar Aaron Lu Committed by Jeff Garzik
Browse files

[libata] PM code cleanup for ata port 



For system freeze, if the port is already runtime suspended, leave it
alone and just return. The port will be resumed on thaw before it will
be used.

And since we will call get_noresume for every device during prepare
phase, and the port is resumed during thaw phase, it can't be in runtime
suspended state during the poweroff phase. So remove the
runtime_suspended check in poweroff callback.

And for all suspend(freeze/suspend/poweroff/etc.), there is no need to
touch the device, so set no_autopsy and no_recovery for them all.

Signed-off-by: default avatarAaron Lu <aaron.lu@intel.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent a7ff60db

drivers/ata/libata-core.c

+4 −12
Original line number Diff line number Diff line
@@ -5333,9 +5333,6 @@ static int ata_port_request_pm(struct ata_port *ap, pm_message_t mesg, 


static int __ata_port_suspend_common(struct ata_port *ap, pm_message_t mesg, int *async)

{

	unsigned int ehi_flags = ATA_EHI_QUIET;

	int rc;



	/*

	 * On some hardware, device fails to respond after spun down

	 * for suspend.  As the device won't be used before being
@@ -5344,11 +5341,9 @@ static int __ata_port_suspend_common(struct ata_port *ap, pm_message_t mesg, int 
	 *

	 * http://thread.gmane.org/gmane.linux.ide/46764

	 */

	if (mesg.event & PM_EVENT_SUSPEND)

		ehi_flags |= ATA_EHI_NO_AUTOPSY | ATA_EHI_NO_RECOVERY;



	rc = ata_port_request_pm(ap, mesg, 0, ehi_flags, async);

	return rc;

	unsigned int ehi_flags = ATA_EHI_QUIET | ATA_EHI_NO_AUTOPSY |

				 ATA_EHI_NO_RECOVERY;

	return ata_port_request_pm(ap, mesg, 0, ehi_flags, async);

}



static int ata_port_suspend_common(struct device *dev, pm_message_t mesg)
@@ -5369,16 +5364,13 @@ static int ata_port_suspend(struct device *dev) 
static int ata_port_do_freeze(struct device *dev)

{

	if (pm_runtime_suspended(dev))

		pm_runtime_resume(dev);

		return 0;



	return ata_port_suspend_common(dev, PMSG_FREEZE);

}



static int ata_port_poweroff(struct device *dev)

{

	if (pm_runtime_suspended(dev))

		return 0;



	return ata_port_suspend_common(dev, PMSG_HIBERNATE);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE