Commit f5d72329 authored Jul 06, 2017 by Gustavo A. R. Silva Committed by Mauro Carvalho Chehab Jul 19, 2017

media: davinci: vpif_capture: constify vb2_ops structure



Check for vb2_ops structures that are only stored in the ops field of a
vb2_queue structure. That field is declared const, so vb2_ops structures
that have this property can be declared as const also.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent b0a4cedd

drivers/media/platform/davinci/vpif_capture.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -312,7 +312,7 @@ static void vpif_stop_streaming(struct vb2_queue *vq)
		spin_unlock_irqrestore(&common->irqlock, flags);
		}

		static struct vb2_ops video_qops = {
		static const struct vb2_ops video_qops = {
		.queue_setup = vpif_buffer_queue_setup,
		.buf_prepare = vpif_buffer_prepare,
		.start_streaming = vpif_start_streaming,

Admin message