sched/fair: Remove unused but set variable 'rq' (f5d6d2da) · Commits · 戴 / test

Since commit: ("sched/fair: Reorder cgroup creation code") ... the variable 'rq' in alloc_fair_sched_group() is set but no longer used. Remove it to fix the following GCC warning when building with 'W=1': kernel/sched/fair.c:8842:13: warning: variable ‘rq’ set but not used [-Wunused-but-set-variable] Signed-off-by:

Tobias Klauser <tklauser@distanz.ch> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161026113704.8981-1-tklauser@distanz.ch Signed-off-by:

Ingo Molnar <mingo@kernel.org>

kernel/sched/fair.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -8839,7 +8839,6 @@ int alloc_fair_sched_group(struct task_group tg, struct task_group parent)
	{		{
	struct sched_entity *se;		struct sched_entity *se;
	struct cfs_rq *cfs_rq;		struct cfs_rq *cfs_rq;
	struct rq *rq;
	int i;		int i;

	tg->cfs_rq = kzalloc(sizeof(cfs_rq) * nr_cpu_ids, GFP_KERNEL);		tg->cfs_rq = kzalloc(sizeof(cfs_rq) * nr_cpu_ids, GFP_KERNEL);
	@@ -8854,8 +8853,6 @@ int alloc_fair_sched_group(struct task_group tg, struct task_group parent)
	init_cfs_bandwidth(tg_cfs_bandwidth(tg));		init_cfs_bandwidth(tg_cfs_bandwidth(tg));

	for_each_possible_cpu(i) {		for_each_possible_cpu(i) {
	rq = cpu_rq(i);

	cfs_rq = kzalloc_node(sizeof(struct cfs_rq),		cfs_rq = kzalloc_node(sizeof(struct cfs_rq),
	GFP_KERNEL, cpu_to_node(i));		GFP_KERNEL, cpu_to_node(i));
	if (!cfs_rq)		if (!cfs_rq)

Admin message