Commit f5d258e6 authored by Marcelo Ricardo Leitner's avatar Marcelo Ricardo Leitner Committed by David S. Miller
Browse files

sctp: reorder sctp_ulpevent and shrink msg_flags 



The next patch needs 8 bytes in there. sctp_ulpevent has a hole due to
bad alignment; msg_flags is using 4 bytes while it actually uses only 2, so
we shrink it, and iif member (4 bytes) which can be easily fetched from
another place once the next patch is there, so we remove it and thus
creating space for 8 bytes.

Signed-off-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9e238323

include/net/sctp/ulpevent.h

+5 −5
Original line number Diff line number Diff line
@@ -48,15 +48,15 @@ 
 */

struct sctp_ulpevent {

	struct sctp_association *asoc;

	__u16 stream;

	__u16 ssn;

	__u16 flags;

	unsigned int rmem_len;

	__u32 ppid;

	__u32 tsn;

	__u32 cumtsn;

	int msg_flags;

	int iif;

	unsigned int rmem_len;

	__u16 stream;

	__u16 ssn;

	__u16 flags;

	__u16 msg_flags;

};



/* Retrieve the skb this event sits inside of. */

net/sctp/ulpevent.c

+2 −2
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ static void sctp_ulpevent_release_frag_data(struct sctp_ulpevent *event); 


/* Initialize an ULP event from an given skb.  */

static void sctp_ulpevent_init(struct sctp_ulpevent *event,

			       int msg_flags,

			       __u16 msg_flags,

			       unsigned int len)

{

	memset(event, 0, sizeof(struct sctp_ulpevent));
@@ -60,7 +60,7 @@ static void sctp_ulpevent_init(struct sctp_ulpevent *event, 
}



/* Create a new sctp_ulpevent.  */

static struct sctp_ulpevent *sctp_ulpevent_new(int size, int msg_flags,

static struct sctp_ulpevent *sctp_ulpevent_new(int size, __u16 msg_flags,

					       gfp_t gfp)

{

	struct sctp_ulpevent *event;

CRA Git | Maintained and supported by SUSTech CRA and CCSE