Commit f5c805b1 authored Nov 03, 2020 by Lee Jones Committed by Bjorn Andersson Nov 10, 2020

soc: qcom: wcnss_ctrl: Demote non-conformant struct header and fix function headers

Fixes the following W=1 kernel build warning(s):

drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'major' not described in 'wcnss_version_resp'
drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'minor' not described in 'wcnss_version_resp'
drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'version' not described in 'wcnss_version_resp'
drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'revision' not described in 'wcnss_version_resp'
drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'rpdev' not described in 'wcnss_ctrl_smd_callback'
drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'priv' not described in 'wcnss_ctrl_smd_callback'
drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'addr' not described in 'wcnss_ctrl_smd_callback'
drivers/soc/qcom/wcnss_ctrl.c:122: warning: Excess function parameter 'channel' description in 'wcnss_ctrl_smd_callback'
drivers/soc/qcom/wcnss_ctrl.c:272: warning: Function parameter or member 'priv' not described in 'qcom_wcnss_open_channel'

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20201103152838.1290217-19-lee.jones@linaro.org

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent fac312df

drivers/soc/qcom/wcnss_ctrl.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -68,9 +68,8 @@ struct wcnss_msg_hdr {
		u32 len;
		} __packed;

		/**
		/*
		* struct wcnss_version_resp - version request response
		* @hdr: common packet wcnss_msg_hdr header
		*/
		struct wcnss_version_resp {
		struct wcnss_msg_hdr hdr;
		@@ -108,9 +107,11 @@ struct wcnss_download_nv_resp {

		/**
		* wcnss_ctrl_smd_callback() - handler from SMD responses
		* @channel: smd channel handle
		* @rpdev: remote processor message device pointer
		* @data: pointer to the incoming data packet
		* @count: size of the incoming data packet
		* @priv: unused
		* @addr: unused
		*
		* Handles any incoming packets from the remote WCNSS_CTRL service.
		*/
		@@ -267,6 +268,7 @@ free_req:
		* @wcnss: wcnss handle, retrieved from drvdata
		* @name: SMD channel name
		* @cb: callback to handle incoming data on the channel
		* @priv: private data for use in the call-back
		*/
		struct rpmsg_endpoint qcom_wcnss_open_channel(void wcnss, const char name, rpmsg_rx_cb_t cb, void priv)
		{

Admin message