Commit f5c754d6 authored Apr 05, 2018 by Colin Ian King Committed by Linus Torvalds Apr 05, 2018

mm/swap_state.c: make bool enable_vma_readahead and swap_vma_readahead() static

The bool enable_vma_readahead and swap_vma_readahead() are local to the
source and do not need to be in global scope, so make them static.

Cleans up sparse warnings:

mm/swap_state.c:41:6: warning: symbol 'enable_vma_readahead' was not declared. Should it be static?
mm/swap_state.c:742:13: warning: symbol 'swap_vma_readahead' was not declared. Should it be static?

Link: http://lkml.kernel.org/r/20180223164852.5159-1-colin.king@canonical.com

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: "Huang, Ying" <ying.huang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3172485f

mm/swap_state.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -38,7 +38,7 @@ static const struct address_space_operations swap_aops = {

		struct address_space *swapper_spaces[MAX_SWAPFILES] __read_mostly;
		static unsigned int nr_swapper_spaces[MAX_SWAPFILES] __read_mostly;
		bool enable_vma_readahead __read_mostly = true;
		static bool enable_vma_readahead __read_mostly = true;

		#define SWAP_RA_WIN_SHIFT (PAGE_SHIFT / 2)
		#define SWAP_RA_HITS_MASK ((1UL << SWAP_RA_WIN_SHIFT) - 1)
		@@ -733,7 +733,7 @@ static void swap_ra_info(struct vm_fault *vmf,
		pte_unmap(orig_pte);
		}

		struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask,
		static struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask,
		struct vm_fault *vmf)
		{
		struct blk_plug plug;