Unverified Commit f5c042b2 authored Nov 13, 2020 by Michał Mirosław Committed by Mark Brown Nov 13, 2020

regulator: workaround self-referent regulators



Workaround regulators whose supply name happens to be the same as its
own name. This fixes boards that used to work before the early supply
resolving was removed. The error message is left in place so that
offending drivers can be detected.

Fixes: aea6cb99 ("regulator: resolve supply after creating regulator")
Cc: stable@vger.kernel.org
Reported-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> # stpmic1
Link: https://lore.kernel.org/r/d703acde2a93100c3c7a81059d716c50ad1b1f52.1605226675.git.mirq-linux@rere.qmqm.pl


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4b639e25

drivers/regulator/core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1844,7 +1844,10 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
		if (r == rdev) {
		dev_err(dev, "Supply for %s (%s) resolved to itself\n",
		rdev->desc->name, rdev->supply_name);
		if (!have_full_constraints())
		return -EINVAL;
		r = dummy_regulator_rdev;
		get_device(&r->dev);
		}

		/*

Admin message