Commit f5be7967 authored Jun 01, 2018 by Yunsheng Lin Committed by David S. Miller Jun 01, 2018

net: hns3: Fix for service_task not running problem after resetting



When hclge_ae_stop is called during resetting, it will cancel the
service_task by calling cancel_work_sync, which may cause the
service_task to exit without clearing HCLGE_STATE_SERVICE_SCHED
bit. If this happens, the service_task will never run again.

This patch fixes this problem by clearing it after calling
cancel_work_sync in hclge_ae_stop.

Fixes: 46a3df9f ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c7fc8fb6

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3748,6 +3748,7 @@ static void hclge_ae_stop(struct hnae3_handle *handle)

		del_timer_sync(&hdev->service_timer);
		cancel_work_sync(&hdev->service_task);
		clear_bit(HCLGE_STATE_SERVICE_SCHED, &hdev->state);

		if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state))
		return;

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1337,6 +1337,7 @@ static void hclgevf_ae_stop(struct hnae3_handle *handle)
		hclgevf_reset_tqp_stats(handle);
		del_timer_sync(&hdev->service_timer);
		cancel_work_sync(&hdev->service_task);
		clear_bit(HCLGEVF_STATE_SERVICE_SCHED, &hdev->state);
		hclgevf_update_link_status(hdev, 0);
		}

Admin message