[NET]: user of the jiffies rounding code: Networking (f5a6e01c) · Commits · 戴 / test

This patch introduces users of the round_jiffies() function in the networking code. These timers all were of the "about once a second" or "about once every X seconds" variety and several showed up in the "what wakes the cpu up" profiles that the tickless patches provide. Some timers are highly dynamic based on network load; but even on low activity systems they still show up so the rounding is done only in cases of low activity, allowing higher frequency timers in the high activity case. The various hardware watchdogs are an obvious case; they run every 2 seconds but aren't otherwise specific of exactly when they need to run. Signed-off-by:

Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/core/dst.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -99,6 +99,13 @@ static void dst_run_gc(unsigned long dummy)
		printk("dst_total: %d/%d %ld\n",
		atomic_read(&dst_total), delayed, dst_gc_timer_expires);
		#endif
		/* if the next desired timer is more than 4 seconds in the future
		* then round the timer to whole seconds
		*/
		if (dst_gc_timer_expires > 4*HZ)
		mod_timer(&dst_gc_timer,
		round_jiffies(jiffies + dst_gc_timer_expires));
		else
		mod_timer(&dst_gc_timer, jiffies + dst_gc_timer_expires);

		out:

net/core/neighbour.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -696,6 +696,9 @@ next_elt:
		if (!expire)
		expire = 1;

		if (expire>HZ)
		mod_timer(&tbl->gc_timer, round_jiffies(now + expire));
		else
		mod_timer(&tbl->gc_timer, now + expire);

		write_unlock(&tbl->lock);

net/sched/sch_generic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -209,7 +209,7 @@ static void dev_watchdog(unsigned long arg)
		dev->name);
		dev->tx_timeout(dev);
		}
		if (!mod_timer(&dev->watchdog_timer, jiffies + dev->watchdog_timeo))
		if (!mod_timer(&dev->watchdog_timer, round_jiffies(jiffies + dev->watchdog_timeo)))
		dev_hold(dev);
		}
		}

Admin message