Commit f59fc7f3 authored Jul 25, 2006 by Tetsuo Handa Committed by David S. Miller Jul 25, 2006

[IPV4/IPV6]: Setting 0 for unused port field in RAW IP recvmsg().



From: Tetsuo Handa from-linux-kernel@i-love.sakura.ne.jp

The recvmsg() for raw socket seems to return random u16 value
from the kernel stack memory since port field is not initialized.
But I'm not sure this patch is correct.
Does raw socket return any information stored in port field?

[ BSD defines RAW IP recvmsg to return a sin_port value of zero.
  This is described in Steven's TCP/IP Illustrated Volume 2 on
  page 1055, which is discussing the BSD rip_input() implementation. ]
    
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 72287490

net/ipv4/raw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -609,6 +609,7 @@ static int raw_recvmsg(struct kiocb iocb, struct sock sk, struct msghdr *msg,
		if (sin) {
		sin->sin_family = AF_INET;
		sin->sin_addr.s_addr = skb->nh.iph->saddr;
		sin->sin_port = 0;
		memset(&sin->sin_zero, 0, sizeof(sin->sin_zero));
		}
		if (inet->cmsg_flags)

net/ipv6/raw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -411,6 +411,7 @@ static int rawv6_recvmsg(struct kiocb iocb, struct sock sk,
		/* Copy the address. */
		if (sin6) {
		sin6->sin6_family = AF_INET6;
		sin6->sin6_port = 0;
		ipv6_addr_copy(&sin6->sin6_addr, &skb->nh.ipv6h->saddr);
		sin6->sin6_flowinfo = 0;
		sin6->sin6_scope_id = 0;

Admin message