Commit f597a579 authored by YueHaibing's avatar YueHaibing Committed by David Howells
Browse files

rxrpc: remove redundant variables 'sp' and 'did_discard' 



Variables 'sp' and 'did_discard' are being assigned,
but are never used, hence they are redundant and can be removed.

fix following warning:

net/rxrpc/call_event.c:165:25: warning: variable 'sp' set but not used [-Wunused-but-set-variable]
net/rxrpc/conn_client.c:1054:7: warning: variable 'did_discard' set but not used [-Wunused-but-set-variable]

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent e6476c21

net/rxrpc/call_event.c

+0 −2
Original line number Diff line number Diff line
@@ -162,7 +162,6 @@ static void rxrpc_congestion_timeout(struct rxrpc_call *call) 
 */

static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j)

{

	struct rxrpc_skb_priv *sp;

	struct sk_buff *skb;

	unsigned long resend_at;

	rxrpc_seq_t cursor, seq, top;
@@ -207,7 +206,6 @@ static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j) 


		skb = call->rxtx_buffer[ix];

		rxrpc_see_skb(skb, rxrpc_skb_tx_seen);

		sp = rxrpc_skb(skb);



		if (anno_type == RXRPC_TX_ANNO_UNACK) {

			if (ktime_after(skb->tstamp, max_age)) {

net/rxrpc/conn_client.c

+0 −2
Original line number Diff line number Diff line
@@ -1051,7 +1051,6 @@ void rxrpc_discard_expired_client_conns(struct work_struct *work) 
		container_of(work, struct rxrpc_net, client_conn_reaper);

	unsigned long expiry, conn_expires_at, now;

	unsigned int nr_conns;

	bool did_discard = false;



	_enter("");
@@ -1113,7 +1112,6 @@ next: 
	 * If someone re-sets the flag and re-gets the ref, that's fine.

	 */

	rxrpc_put_connection(conn);

	did_discard = true;

	nr_conns--;

	goto next;

CRA Git | Maintained and supported by SUSTech CRA and CCSE