Commit f5956faf authored by Or Gerlitz's avatar Or Gerlitz Committed by David S. Miller
Browse files

net/mlx4_core: Fix wrong mask and error flow for the update-qp command 



The bit mask for currently supported driver features (MLX4_UPDATE_QP_SUPPORTED_ATTRS)
of the update-qp command was defined twice (using enum value and pre-processor
define directive) and wrong.

The return value of the call to mlx4_update_qp() from within the SRIOV
resource-tracker was wrongly voided down.

Fix both issues.

issue: none
Fixes: 09e05c3f ('net/mlx4: Set vlan stripping policy by the right command')
Fixes: ce8d9e0d ('net/mlx4_core: Add UPDATE_QP SRIOV wrapper support')
Signed-off-by: default avatarMatan Barak <matanb@mellanox.com>
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 38674a49

drivers/net/ethernet/mellanox/mlx4/qp.c

+0 −1
Original line number Diff line number Diff line
@@ -412,7 +412,6 @@ err_icm: 


EXPORT_SYMBOL_GPL(mlx4_qp_alloc);



#define MLX4_UPDATE_QP_SUPPORTED_ATTRS MLX4_UPDATE_QP_SMAC

int mlx4_update_qp(struct mlx4_dev *dev, u32 qpn,

		   enum mlx4_update_qp_attr attr,

		   struct mlx4_update_qp_params *params)

drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

+6 −3
Original line number Diff line number Diff line
@@ -713,7 +713,7 @@ static int update_vport_qp_param(struct mlx4_dev *dev, 
	struct mlx4_vport_oper_state *vp_oper;

	struct mlx4_priv *priv;

	u32 qp_type;

	int port;

	int port, err = 0;



	port = (qpc->pri_path.sched_queue & 0x40) ? 2 : 1;

	priv = mlx4_priv(dev);
@@ -738,7 +738,9 @@ static int update_vport_qp_param(struct mlx4_dev *dev, 
			} else {

				struct mlx4_update_qp_params params = {.flags = 0};



				mlx4_update_qp(dev, qpn, MLX4_UPDATE_QP_VSD, &params);

				err = mlx4_update_qp(dev, qpn, MLX4_UPDATE_QP_VSD, &params);

				if (err)

					goto out;

			}

		}
@@ -773,7 +775,8 @@ static int update_vport_qp_param(struct mlx4_dev *dev, 
		qpc->pri_path.feup |= MLX4_FSM_FORCE_ETH_SRC_MAC;

		qpc->pri_path.grh_mylmc = (0x80 & qpc->pri_path.grh_mylmc) + vp_oper->mac_idx;

	}

	return 0;

out:

	return err;

}



static int mpt_mask(struct mlx4_dev *dev)

include/linux/mlx4/qp.h

+1 −1
Original line number Diff line number Diff line
@@ -427,7 +427,7 @@ struct mlx4_wqe_inline_seg { 


enum mlx4_update_qp_attr {

	MLX4_UPDATE_QP_SMAC		= 1 << 0,

	MLX4_UPDATE_QP_VSD		= 1 << 2,

	MLX4_UPDATE_QP_VSD		= 1 << 1,

	MLX4_UPDATE_QP_SUPPORTED_ATTRS	= (1 << 2) - 1

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE