Commit f5942db5 authored by Steve French's avatar Steve French
Browse files

cifs: smb2 commands can not be negative, remove confusing check 



As Coverity points out le16_to_cpu(midEntry->Command) can not be
less than zero.

Detected by CoverityScan, CID#1438650 ("Macro compares unsigned to 0")

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
parent 0967e545

fs/cifs/transport.c

+5 −3
Original line number Diff line number Diff line
@@ -126,9 +126,11 @@ DeleteMidQEntry(struct mid_q_entry *midEntry) 
	if ((slow_rsp_threshold != 0) &&

	    time_after(now, midEntry->when_alloc + (slow_rsp_threshold * HZ)) &&

	    (midEntry->command != command)) {

		/* smb2slowcmd[NUMBER_OF_SMB2_COMMANDS] counts by command */

		if ((le16_to_cpu(midEntry->command) < NUMBER_OF_SMB2_COMMANDS) &&

		    (le16_to_cpu(midEntry->command) >= 0))

		/*

		 * smb2slowcmd[NUMBER_OF_SMB2_COMMANDS] counts by command

		 * NB: le16_to_cpu returns unsigned so can not be negative below

		 */

		if (le16_to_cpu(midEntry->command) < NUMBER_OF_SMB2_COMMANDS)

			cifs_stats_inc(&midEntry->server->smb2slowcmd[le16_to_cpu(midEntry->command)]);



		trace_smb3_slow_rsp(le16_to_cpu(midEntry->command),

CRA Git | Maintained and supported by SUSTech CRA and CCSE