Commit f58876ac authored Jul 18, 2013 by Dan Carpenter Committed by Guenter Roeck Aug 11, 2013

hwmon: (nct6775) Fix size of data->temp array



Smatch complains that we have a array overflow:

	drivers/hwmon/nct6775.c:1456 nct6775_update_device()
		error: buffer overflow 'data->temp' 4 <= 4

Guenter Roeck says that the array should have been made larger in
7cbbd6aee6 (Add support for critical low/high temperature limits on
NCT6106).  This patch does that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent df612d5f

drivers/hwmon/nct6775.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -813,8 +813,8 @@ struct nct6775_data {
		u8 temp_fixed_num; /* 3 or 6 */
		u8 temp_type[NUM_TEMP_FIXED];
		s8 temp_offset[NUM_TEMP_FIXED];
		s16 temp[4][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst,
		* 3=temp_crit */
		s16 temp[5][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst,
		* 3=temp_crit, 4=temp_lcrit */
		u64 alarms;
		u64 beeps;

Admin message