Commit f57c4bbf authored Apr 03, 2019 by Dan Carpenter Committed by Marcel Holtmann Apr 23, 2019

6lowpan: Off by one handling ->nexthdr



NEXTHDR_MAX is 255.  What happens here is that we take a u8 value
"hdr->nexthdr" from the network and then look it up in
lowpan_nexthdr_nhcs[].  The problem is that if hdr->nexthdr is 0xff then
we read one element beyond the end of the array so the array needs to
be one element larger.

Fixes: 92aa7c65 ("6lowpan: add generic nhc layer interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Acked-by: Alexander Aring <aring@mojatatu.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent 50357261

net/6lowpan/nhc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -18,7 +18,7 @@
		#include "nhc.h"

		static struct rb_root rb_root = RB_ROOT;
		static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX];
		static struct lowpan_nhc *lowpan_nexthdr_nhcs[NEXTHDR_MAX + 1];
		static DEFINE_SPINLOCK(lowpan_nhc_lock);

		static int lowpan_nhc_insert(struct lowpan_nhc *nhc)

Admin message