Commit f56e2947 authored by Sean MacLennan's avatar Sean MacLennan Committed by Al Viro
Browse files

The rtl8192e procfs-based debug interface seems very broken 



The procfs debug code in rtl_debug.c is, ironically, very buggy: it lacks proper locking.
Since the most useful part of the code (the stats) are available through more
standard APIs, I think it is best to just delete the whole mess.

Signed-off-by: default avatarSean MacLennan <seanm@seanm.ca>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent c037773c

drivers/staging/rtl8192e/rtl8192e/Makefile

+0 −1
Original line number Diff line number Diff line
@@ -7,7 +7,6 @@ r8192e_pci-objs := \ 
	r8190P_rtl8256.o	\

	rtl_cam.o		\

	rtl_core.o		\

	rtl_debug.o		\

	rtl_dm.o		\

	rtl_eeprom.o		\

	rtl_ethtool.o		\

drivers/staging/rtl8192e/rtl8192e/rtl_core.c

+0 −5
Original line number Diff line number Diff line
@@ -2966,8 +2966,6 @@ static int rtl8192_pci_probe(struct pci_dev *pdev, 
		goto err_free_irq;

	RT_TRACE(COMP_INIT, "dev name: %s\n", dev->name);



	rtl8192_proc_init_one(dev);



	if (priv->polling_timer_on == 0)

		check_rfctrl_gpio_timer((unsigned long)dev);
@@ -3003,7 +3001,6 @@ static void rtl8192_pci_disconnect(struct pci_dev *pdev) 
		del_timer_sync(&priv->gpio_polling_timer);

		cancel_delayed_work(&priv->gpio_change_rf_wq);

		priv->polling_timer_on = 0;

		rtl8192_proc_remove_one(dev);

		rtl8192_down(dev, true);

		deinit_hal_dm(dev);

		if (priv->pFirmware) {
@@ -3093,7 +3090,6 @@ static int __init rtl8192_pci_module_init(void) 
	printk(KERN_INFO "\nLinux kernel driver for RTL8192E WLAN cards\n");

	printk(KERN_INFO "Copyright (c) 2007-2008, Realsil Wlan Driver\n");



	rtl8192_proc_module_init();

	if (0 != pci_register_driver(&rtl8192_pci_driver)) {

		DMESG("No device found");

		/*pci_unregister_driver (&rtl8192_pci_driver);*/
@@ -3107,7 +3103,6 @@ static void __exit rtl8192_pci_module_exit(void) 
	pci_unregister_driver(&rtl8192_pci_driver);



	RT_TRACE(COMP_DOWN, "Exiting");

	rtl8192_proc_module_remove();

}



void check_rfctrl_gpio_timer(unsigned long data)

drivers/staging/rtl8192e/rtl8192e/rtl_core.h

+0 −6
Original line number Diff line number Diff line
@@ -1085,10 +1085,4 @@ void ActUpdateChannelAccessSetting(struct net_device *dev, 
			   enum wireless_mode WirelessMode,

			   struct channel_access_setting *ChnlAccessSetting);



/* proc stuff from rtl_debug.c */

void rtl8192_proc_init_one(struct net_device *dev);

void rtl8192_proc_remove_one(struct net_device *dev);

void rtl8192_proc_module_init(void);

void rtl8192_proc_module_remove(void);



#endif

drivers/staging/rtl8192e/rtl8192e/rtl_debug.c

deleted100644 → 0
+0 −1029

File deleted.

Preview size limit exceeded, changes collapsed.

CRA Git | Maintained and supported by SUSTech CRA and CCSE