Commit f5487145 authored by Len Brown's avatar Len Brown
Browse files

ACPI: thermal: create "thermal.nocrt" to disable critical actions 



thermal.nocrt=1 disables actions on _CRT and _HOT
ACPI thermal zone trip-points.  They will be marked
as <disabled> in /proc/acpi/thermal_zone/*/trip_points.

There are two cases where this option is used:

1. Debugging a hot system crossing valid trip point.

   If your system fan is spinning at full speed,
   be sure that the vent is not clogged with dust.
   Many laptops have very fine thermal fins that are easily blocked.

   Check that the processor fan-sink is properly seated,
   has the proper thermal grease, and is really spinning.

   Check for fan related options in BIOS SETUP.
   Sometimes there is a performance vs quiet option.
   Defaults are generally the most conservative.

   If your fan is not spinning, yet /proc/acpi/fan/
   has files in it, please file a Linux/ACPI bug.

   WARNING: you risk shortening the lifetime of your
   hardware if you use this parameter on a hot system.
   Note that this refers to all system components,
   including the disk drive.

2. Working around a cool system crossing critical
   trip point due to erroneous temperature reading.

   Try again with CONFIG_HWMON=n
   There is known potential for conflict between the
   the hwmon sub-system and the ACPI BIOS.
   If this fixes it, notify lm-sensors@lm-sensors.org
   and linux-acpi@vger.kernel.org

   Otherwise, file a Linux/ACPI bug, or notify
   just linux-acpi@vger.kernel.org.

Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent a70cdc52

Documentation/kernel-parameters.txt

+4 −0
Original line number Diff line number Diff line
@@ -1820,6 +1820,10 @@ and is between 256 and 4096 characters. It is defined in the file 
	thash_entries=	[KNL,NET]

			Set number of hash buckets for TCP connection



	thermal.nocrt=	[HW,ACPI]

			Set to disable actions on ACPI thermal zone

			critical and hot trip points.



	thermal.off=	[HW,ACPI]

			1: disable ACPI thermal control

drivers/acpi/thermal.c

+12 −6
Original line number Diff line number Diff line
@@ -78,6 +78,10 @@ static int tzp; 
module_param(tzp, int, 0444);

MODULE_PARM_DESC(tzp, "Thermal zone polling frequency, in 1/10 seconds.\n");



static int nocrt;

module_param(nocrt, int, 0);

MODULE_PARM_DESC(nocrt, "Set to disable action on ACPI thermal zone critical and hot trips.\n");



static int off;

module_param(off, int, 0);

MODULE_PARM_DESC(off, "Set to disable ACPI thermal support.\n");
@@ -442,7 +446,7 @@ static int acpi_thermal_get_devices(struct acpi_thermal *tz) 


static int acpi_thermal_critical(struct acpi_thermal *tz)

{

	if (!tz || !tz->trips.critical.flags.valid)

	if (!tz || !tz->trips.critical.flags.valid || nocrt)

		return -EINVAL;



	if (tz->temperature >= tz->trips.critical.temperature) {
@@ -464,7 +468,7 @@ static int acpi_thermal_critical(struct acpi_thermal *tz) 


static int acpi_thermal_hot(struct acpi_thermal *tz)

{

	if (!tz || !tz->trips.hot.flags.valid)

	if (!tz || !tz->trips.hot.flags.valid || nocrt)

		return -EINVAL;



	if (tz->temperature >= tz->trips.hot.temperature) {
@@ -839,12 +843,14 @@ static int acpi_thermal_trip_seq_show(struct seq_file *seq, void *offset) 
		goto end;



	if (tz->trips.critical.flags.valid)

		seq_printf(seq, "critical (S5):           %ld C\n",

			   KELVIN_TO_CELSIUS(tz->trips.critical.temperature));

		seq_printf(seq, "critical (S5):           %ld C%s",

			   KELVIN_TO_CELSIUS(tz->trips.critical.temperature),

			   nocrt ? " <disabled>\n" : "\n");



	if (tz->trips.hot.flags.valid)

		seq_printf(seq, "hot (S4):                %ld C\n",

			   KELVIN_TO_CELSIUS(tz->trips.hot.temperature));

		seq_printf(seq, "hot (S4):                %ld C%s",

			   KELVIN_TO_CELSIUS(tz->trips.hot.temperature),

			   nocrt ? " <disabled>\n" : "\n");



	if (tz->trips.passive.flags.valid) {

		seq_printf(seq,

CRA Git | Maintained and supported by SUSTech CRA and CCSE