Commit f530c196 authored Nov 05, 2019 by Yan-Hsuan Chuang Committed by Kalle Valo Nov 06, 2019

rtw88: fix potential NULL pointer access for firmware



Driver could access a NULL firmware pointer if we don't
return here.

Fixes: 5195b904 ("rtw88: avoid FW info flood")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 5174f1e4

drivers/net/wireless/realtek/rtw88/main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1024,8 +1024,10 @@ static void rtw_load_firmware_cb(const struct firmware firmware, void context)
		struct rtw_fw_state *fw = &rtwdev->fw;
		const struct rtw_fw_hdr *fw_hdr;

		if (!firmware)
		if (!firmware \|\| !firmware->data) {
		rtw_err(rtwdev, "failed to request firmware\n");
		return;
		}

		fw_hdr = (const struct rtw_fw_hdr *)firmware->data;
		fw->h2c_version = le16_to_cpu(fw_hdr->h2c_fmt_ver);

Admin message