Commit f517700c authored Mar 26, 2015 by Ying Xue Committed by Paul E. McKenney May 27, 2015

rculist: Fix another sparse warning

This fixes the following sparse warnings:

make C=1 CF=-D__CHECK_ENDIAN__ net/tipc/name_table.o
net/tipc/name_table.c:977:17: error: incompatible types in comparison expression (different address spaces)
net/tipc/name_table.c:977:17: error: incompatible types in comparison expression (different address spaces)

To silence these spare complaints, an RCU annotation should be added to
"next" pointer of hlist_node structure through hlist_next_rcu() macro
when iterating over a hlist with hlist_for_each_entry_from_rcu().

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

parent 82072c4f

include/linux/rculist.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -549,8 +549,8 @@ static inline void hlist_add_behind_rcu(struct hlist_node *n,
		*/
		#define hlist_for_each_entry_from_rcu(pos, member) \
		for (; pos; \
		pos = hlist_entry_safe(rcu_dereference((pos)->member.next),\
		typeof(*(pos)), member))
		pos = hlist_entry_safe(rcu_dereference_raw(hlist_next_rcu( \
		&(pos)->member)), typeof(*(pos)), member))

		#endif /* __KERNEL__ */
		#endif

Admin message