rxrpc: Use call->peer rather than call->conn->params.peer (f4fdb352) · Commits · 戴 / test

Use call->peer rather than call->conn->params.peer to avoid the possibility of call->conn being NULL and, whilst we're at it, check it for NULL before we access it. Signed-off-by:

David Howells <dhowells@redhat.com>

net/rxrpc/call_object.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -514,9 +514,11 @@ void rxrpc_release_call(struct rxrpc_call *call)
		*/
		_debug("RELEASE CALL %p (%d CONN %p)", call, call->debug_id, conn);

		spin_lock(&conn->params.peer->lock);
		if (call->peer) {
		spin_lock(&call->peer->lock);
		hlist_del_init(&call->error_link);
		spin_unlock(&conn->params.peer->lock);
		spin_unlock(&call->peer->lock);
		}

		write_lock_bh(&rx->call_lock);
		if (!list_empty(&call->accept_link)) {

Admin message