Commit f4fd4ae3 authored by Vivek Goyal's avatar Vivek Goyal Committed by Miklos Szeredi
Browse files

virtiofs: get rid of no_mount_options 



This option was introduced so that for virtio_fs we don't show any mounts
options fuse_show_options(). Because we don't offer any of these options
to be controlled by mounter.

Very soon we are planning to introduce option "dax" which mounter should
be able to specify. And no_mount_options does not work anymore.


Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent b43b7e81

fs/fuse/fuse_i.h

+4 −4
Original line number Diff line number Diff line
@@ -482,7 +482,7 @@ struct fuse_fs_context { 
	bool destroy:1;

	bool no_control:1;

	bool no_force_umount:1;

	bool no_mount_options:1;

	bool legacy_opts_show:1;

	unsigned int max_read;

	unsigned int blksize;

	const char *subtype;
@@ -610,6 +610,9 @@ struct fuse_conn { 
	/** cache READLINK responses in page cache */

	unsigned cache_symlinks:1;



	/* show legacy mount options */

	unsigned int legacy_opts_show:1;



	/*

	 * The following bitfields are only for optimization purposes

	 * and hence races in setting them will not cause malfunction
@@ -717,9 +720,6 @@ struct fuse_conn { 
	/** Do not allow MNT_FORCE umount */

	unsigned int no_force_umount:1;



	/* Do not show mount options */

	unsigned int no_mount_options:1;



	/** The number of requests waiting for completion */

	atomic_t num_waiting;

fs/fuse/inode.c

+16 −14
Original line number Diff line number Diff line
@@ -573,11 +573,11 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root) 
	struct super_block *sb = root->d_sb;

	struct fuse_conn *fc = get_fuse_conn_super(sb);



	if (fc->no_mount_options)

		return 0;



	seq_printf(m, ",user_id=%u", from_kuid_munged(fc->user_ns, fc->user_id));

	seq_printf(m, ",group_id=%u", from_kgid_munged(fc->user_ns, fc->group_id));

	if (fc->legacy_opts_show) {

		seq_printf(m, ",user_id=%u",

			   from_kuid_munged(fc->user_ns, fc->user_id));

		seq_printf(m, ",group_id=%u",

			   from_kgid_munged(fc->user_ns, fc->group_id));

		if (fc->default_permissions)

			seq_puts(m, ",default_permissions");

		if (fc->allow_other)
@@ -586,6 +586,7 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root) 
			seq_printf(m, ",max_read=%u", fc->max_read);

		if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)

			seq_printf(m, ",blksize=%lu", sb->s_blocksize);

	}

	return 0;

}
@@ -1196,11 +1197,11 @@ int fuse_fill_super_common(struct super_block *sb, struct fuse_fs_context *ctx) 
	fc->allow_other = ctx->allow_other;

	fc->user_id = ctx->user_id;

	fc->group_id = ctx->group_id;

	fc->legacy_opts_show = ctx->legacy_opts_show;

	fc->max_read = max_t(unsigned, 4096, ctx->max_read);

	fc->destroy = ctx->destroy;

	fc->no_control = ctx->no_control;

	fc->no_force_umount = ctx->no_force_umount;

	fc->no_mount_options = ctx->no_mount_options;



	err = -ENOMEM;

	root = fuse_get_root_inode(sb, ctx->rootmode);
@@ -1325,6 +1326,7 @@ static int fuse_init_fs_context(struct fs_context *fc) 


	ctx->max_read = ~0;

	ctx->blksize = FUSE_DEFAULT_BLKSIZE;

	ctx->legacy_opts_show = true;



#ifdef CONFIG_BLOCK

	if (fc->fs_type == &fuseblk_fs_type) {

fs/fuse/virtio_fs.c

+0 −1
Original line number Diff line number Diff line
@@ -1096,7 +1096,6 @@ static int virtio_fs_fill_super(struct super_block *sb) 
		.destroy = true,

		.no_control = true,

		.no_force_umount = true,

		.no_mount_options = true,

	};



	mutex_lock(&virtio_fs_mutex);

CRA Git | Maintained and supported by SUSTech CRA and CCSE