ACPI: Remove unused lockable in acpi_device_flags (f4fa0e01) · Commits · 戴 / test

Removed lockable in struct acpi_device_flags since it is no longer used by any code. acpi_bus_hot_remove_device() cannot use this flag because acpi_bus_trim() frees up its acpi_device object. Furthermore, the dock driver calls _LCK method without using this lockable flag. Signed-off-by:

Toshi Kani <toshi.kani@hp.com> Reviewed-by:

Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Signed-off-by:

Rafael J. Wysocki <rafael.j.wysocki@intel.com>

drivers/acpi/scan.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1017,11 +1017,6 @@ static int acpi_bus_get_flags(struct acpi_device *device)
		device->flags.ejectable = 1;
		}

		/* Presence of _LCK indicates 'lockable' */
		status = acpi_get_handle(device->handle, "_LCK", &temp);
		if (ACPI_SUCCESS(status))
		device->flags.lockable = 1;

		/* Power resources cannot be power manageable. */
		if (device->device_type == ACPI_BUS_TYPE_POWER)
		return 0;

include/acpi/acpi_bus.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -144,12 +144,11 @@ struct acpi_device_flags {
		u32 bus_address:1;
		u32 removable:1;
		u32 ejectable:1;
		u32 lockable:1;
		u32 suprise_removal_ok:1;
		u32 power_manageable:1;
		u32 performance_manageable:1;
		u32 eject_pending:1;
		u32 reserved:23;
		u32 reserved:24;
		};

		/* File System */

Admin message